Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueParser: rename publicly exposed function names to indicate they are parsers #674

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 6, 2024

Changelog

- description: |
    ValueParser: rename publicly exposed function names to indicate they are parsers
    
    To adapt: prefix old function name by `parse` and everything should compile again.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

It's only renamings

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Nov 6, 2024

The third commit is optional, since it only concerns names that are not exposed.

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@smelc smelc force-pushed the smelc/indicate-parsers-in-function-names branch from 2e97309 to 9eec32e Compare November 6, 2024 14:36
@smelc smelc force-pushed the smelc/indicate-parsers-in-function-names branch from 9eec32e to 7bb45d9 Compare November 7, 2024 09:33
@smelc smelc enabled auto-merge November 7, 2024 09:34
@smelc smelc added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit 511472f Nov 7, 2024
25 checks passed
@smelc smelc deleted the smelc/indicate-parsers-in-function-names branch November 7, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename functions in ValueParser.hs, to indicate in the name they are parsers
3 participants