Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix estmated fee rendering #873

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Aug 22, 2024

Changelog

- description: |
    Fix estimated fee rendering: previously the output was of the form `Estimated transaction fee: Coin 357154`.
    Now it is: `Estimated transaction fee: 357154 Lovelace`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Previously estimated fee was rendered as:

Estimated transaction fee: Coin 357154

After the change:

Estimated transaction fee: 357154 Lovelace

This PR changes also some text highlighting in the help text to make it consistent.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer marked this pull request as ready for review August 22, 2024 14:19
@carbolymer carbolymer force-pushed the mgalazyn/fix/estimated-fee-rendering branch from 0140cdd to 83a4db6 Compare August 22, 2024 14:20
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer> LGTM but could you add a golden test that calls the estimate command? I'm surprised we don't track the shape of the output.

@carbolymer
Copy link
Contributor Author

@smelc I'd have to do this in cardano-testnet, since this is a part of an online command transaction build.

@smelc
Copy link
Contributor

smelc commented Aug 23, 2024

@smelc I'd have to do this in cardano-testnet, since this is a part of an online command transaction build.

@carbolymer> ah I missed that. Nevermind then.

@carbolymer carbolymer added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit a59ce92 Aug 23, 2024
26 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/estimated-fee-rendering branch August 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants