Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url support to metadata hash cmd #927

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Add url support to metadata hash cmd #927

merged 5 commits into from
Oct 8, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 7, 2024 •
edited
Loading

Changelog

- description: |
    Added URL support to `governance drep metadata-hash`
  type:
  - feature        # introduces a new feature

Context

This PR adds URL support to governance drep metadata-hash for consistency with hash anchor-data (see #895).

How to trust this PR

I have added a couple of tests, but a lot of functionality from #895 is reused.

There are three commits:

  • One for the implementation
  • One for the tests
  • One for running prettify in a module that was not well formatted because of CPP flags

I would look at them individually, because the last one is very noisy but just formatting

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Oct 7, 2024
@palas palas self-assigned this Oct 7, 2024
@palas palas linked an issue Oct 7, 2024 that may be closed by this pull request
[FR] - Add File Hash Validation when Building Transaction #882
Closed
@palas palas force-pushed the add-url-support-to-metadata-hash-cmd branch 3 times, most recently from 3cfc61d to db10c8f Compare October 7, 2024 21:25
@palas palas changed the base branch from main to add-hash-validation3 October 7, 2024 21:56
smelc
smelc approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 I've left a couple of comments.

cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/EraBased/Commands/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/test/cardano-cli-golden/files/golden/help.cli Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/DRep.hs Outdated Show resolved Hide resolved
cardano-cli/test/cardano-cli-test/Test/Cli/DRepMetadata.hs Show resolved Hide resolved
@palas palas requested a review from carbolymer October 8, 2024 13:21
Base automatically changed from add-hash-validation3 to main October 8, 2024 14:40
@palas palas force-pushed the add-url-support-to-metadata-hash-cmd branch from 1265d19 to 28d3c1b Compare October 8, 2024 15:18
@palas palas added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 7d13953 Oct 8, 2024
25 checks passed
@palas palas deleted the add-url-support-to-metadata-hash-cmd branch October 8, 2024 17:01
@palas palas mentioned this pull request Oct 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

@carbolymer carbolymer Awaiting requested review from carbolymer

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Add File Hash Validation when Building Transaction
3 participants
@palas @carbolymer @smelc