Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hash checks for governance committee create-cold-key-resignation-certificate and governance vote create #937

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Add hash checks for governance committee create-cold-key-resignation-certificate and governance vote create #937

merged 7 commits into from
Oct 16, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 15, 2024

Changelog

- description: |
    Added hash checks for `governance committee create-cold-key-resignation-certificate` and `governance vote create`
  type:
  - feature
  - test

Context

This is another step forward on addressing #882.

This PR adds checks to two commands:

  • governance committee create-cold-key-resignation-certificate
  • governance vote create

It also generalizes the carryHashChecks function to be able to reuse it more.

How to trust this PR

There are tests for all new functionality (both positive and negative). Most code is reused, and the one that is not is completely analogous to other PRs.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added enhancement New feature or request test Modifies/extends the test suite labels Oct 15, 2024
@palas palas self-assigned this Oct 15, 2024
@palas palas linked an issue Oct 15, 2024 that may be closed by this pull request
[FR] - Add File Hash Validation when Building Transaction #882
Closed
@palas palas marked this pull request as ready for review October 15, 2024 12:10
Jimbo4350
Jimbo4350 requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove _pcaAnchor as it's not strictly necessary. I want our lens usage constrained to what the ledger api exposes.

cardano-cli/src/Cardano/CLI/EraBased/Commands/Governance/Committee.hs Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Types/Common.hs Outdated Show resolved Hide resolved
@palas palas requested a review from Jimbo4350 October 15, 2024 13:26
@palas palas added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit cc97ba4 Oct 16, 2024
27 checks passed
@palas palas deleted the add-hash-validation5 branch October 16, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@carbolymer carbolymer Awaiting requested review from carbolymer

@smelc smelc Awaiting requested review from smelc

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@palas palas

Labels
enhancement New feature or request test Modifies/extends the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Add File Hash Validation when Building Transaction
2 participants
@palas @Jimbo4350