Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependencies from cardano-ledger-* #941

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 17, 2024

Changelog

- description: |
    Removed dependencies from `cardano-ledger-shelley`, `cardano-ledger-core`, and `cardano-ledger-api`.
  type:
  - refactoring    # QoL changes

Context

As part of the work targeted at addressing issues pointed out in IntersectMBO/cardano-api#608, this PR aims to remove all direct dependencies of cardano-cli from ledger.

How to trust this PR

Make sure it is just a refactoring.

Look at it in conjunction with: IntersectMBO/cardano-api#656

Take advantage that there are one commit for shelley, one for core, and one for api (same for the corresponding PR in cardano-api)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas changed the title Remove transitive deps ledger2 Remove direct dependencies from cardano-ledger-* Oct 17, 2024
@palas palas force-pushed the remove-transitive-deps-ledger2 branch 2 times, most recently from 308f547 to 4ab4ff0 Compare October 17, 2024 13:39
@palas palas self-assigned this Oct 17, 2024
@palas palas force-pushed the remove-transitive-deps-ledger2 branch 2 times, most recently from 97e93c3 to c352284 Compare October 18, 2024 11:41
@palas palas force-pushed the remove-transitive-deps-ledger2 branch from c352284 to 2f8cfb0 Compare October 21, 2024 17:06
@palas palas enabled auto-merge October 21, 2024 17:07
@palas palas added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit bc62e86 Oct 21, 2024
25 checks passed
@palas palas deleted the remove-transitive-deps-ledger2 branch October 21, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Documentation and Integration Clarification
2 participants