-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anchor hash checks to transaction build
#951
base: master
Are you sure you want to change the base?
Conversation
15286a9
to
4da36e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those hash checking bits should go to cardano-api
. It feels like it's a reusable code, which we could expose to api users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @carbolymer . Those changes need to be made first.
78f05e0
to
5e8cbc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I don't agree with AnchorDataFromCertificateException
as a name. I made a comment on the relevant api PR.
0564c0e
to
114680d
Compare
114680d
to
ca3eee5
Compare
Co-authored-by: Mateusz Galazyn <[email protected]>
dbe20bf
to
d854349
Compare
Changelog
Context
This is part of work related to solving #882. Each individual command has optional checks for verifying the hash matches the anchor data. But this PR adds a check to
transaction build
which combines the pieces and creates the actual transaction (so it is one of the last steps).Related PRs
How to trust this PR
You can see the new test in this PR in
cardano-testnet
and the old tests updated to pass.Checklist