Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release cardano-ledger-byron #925

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Oct 11, 2024

From https://github.com/input-output-hk/cardano-ledger at 3b8090905773bc8990755576d9fa7a5edf07e80d

@teodanciu teodanciu force-pushed the td/release-byron-take2 branch 5 times, most recently from 37ef4c5 to d2f1eee Compare October 11, 2024 17:16
@teodanciu teodanciu marked this pull request as ready for review October 11, 2024 18:16
@Lucsanszky
Copy link
Contributor

Actually, we can add a revision instead of making a PR in ledger with the Cabal >=3.12 constraint. That way, we can use the same commit hash for the release as in #916 (0ba8e73c41847142e0bed09e09a8aa166fc10384).

@Lucsanszky
Copy link
Contributor

Lucsanszky commented Oct 11, 2024

@neilmayhew indicated that the Cabal >=3.12 constraint 'hack' might be problematic due to the fact that GHC 8.10.7 is bundled with Cabal 3.2.1.0. Are we okay to add this revision anyway, until haskell.nix is updated in a non-breaking way? Actually, let me try something so we don't have to add Cabal >=3.12.

cc @disassembler

@neilmayhew
Copy link

the Cabal >=3.12 constraint 'hack' might be problematic due to the fact that GHC 8.10.7 is bundled with Cabal 3.2.1.0

I was wrong about that (which is just as well, otherwise the revision wouldn't have worked either). The constraint is OK because nix/builder.nix adds --allow-boot-library-installs to the Cabal project's configureArgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants