Ensure we always have a collateral input. #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where we require collateral, we need to ensure that at least one input gets spent, for replay protection purposes. Normally this will be ensured by a collateral percentage > 0, but just in case, and to make sure that we can't shoot ourselves in the foot, we check that if the Tx _can_ fail in 2-phase validation, then we must have at least one collateral input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where we require collateral, we need to ensure that at least
one input gets spent, for replay protection purposes. Normally this will
be ensured by a collateral percentage > 0, but just in case, and to make
sure that we can't shoot ourselves in the foot, we check that if the Tx
can fail in 2-phase validation, then we must have at least one
collateral input.