Define 'GetLedgerView' for Babbage. #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This instance is a little (well, a lot) suspicious, since we don't
actually have extra entropy in Babbage. We rely on the fact that this
type is only used to construct the `Praos` ledger view, which is much
simler (it looks like this:
```
data LedgerView crypto = LedgerView
{ -- | Stake distribution
lvPoolDistr :: SL.PoolDistr crypto,
-- | Maximum header size
lvMaxHeaderSize :: !Natural,
-- | Maximum block body size
lvMaxBodySize :: !Natural
}
deriving (Show)
```
). So the `error` field will be thrown away without being evaluated.
At some point we should make this situation better, but not before the
Vasil HF.
| } = | ||
| LedgerView | ||
| { lvD = getField @"_d" . esPp $ nesEs, | ||
| lvExtraEntropy = error "Extra entropy is not set in the Babbage era", |
There was a problem hiding this comment.
maybe it would be less scary to use the neutral nonce? though perhaps failing hard is better? 🤔
There was a problem hiding this comment.
I'm inclined to go for failing hard, though I could be argued the other way!
There was a problem hiding this comment.
Let's fail hard!
Do not go gentle into that good night,
Old age should burn and rave at close of day;
Rage, rage against the dying of the light.
JaredCorduan
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instance is a little (well, a lot) suspicious, since we don't
actually have extra entropy in Babbage. We rely on the fact that this
type is only used to construct the
Praosledger view, which is muchsimler (it looks like this:
). So the
errorfield will be thrown away without being evaluated.At some point we should make this situation better, but not before the
Vasil HF.