Add versioned CBOR instances for crypto primitives #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/add-cbor-instances-praosvrf
branch
from
10a1bc2
to
645a7ae
Compare
|
@lehins - I forgot about the changelog, we should add all this goodness to it. |
I didn't, there is already an entry in changelog:
I'll add more PR numbers to that entry once the work is complete |
|
😄 I did however made a mistake on the PR number. I'll fix that |
lehins
force-pushed
the
lehins/add-cbor-instances-praosvrf
branch
3 times, most recently
from
7e21448
to
f26a3ae
Compare
lehins
force-pushed
the
lehins/add-cbor-instances-praosvrf
branch
from
f26a3ae
to
8bef61a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all ToCBOR and FromCBOR instances from
cardano-crypto-classandcardano-crypto-praospackages. Actual decoders are still defined incardano-crypto-classInstances for
PraosVRFin this PR depends on IntersectMBO/cardano-base#316