Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust semantics of ConwayWdrlNotDelegatedToDRep #4715

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Oct 23, 2024

Description

Previous semantics did not allow to withdraw rewards and deregister in the same transaction, because deregistration would effectively clear out delegation to a DRep, thus preventing withdrawals.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Previous semantics did not allow to withdraw rewards and deregister in
the same transaction, because deregistration would effectively clear
out delegation to a DRep, thus preventing withdrawals
@lehins lehins requested a review from a team as a code owner October 23, 2024 18:13
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins enabled auto-merge October 23, 2024 20:22
@lehins lehins merged commit 5357a85 into master Oct 23, 2024
153 of 154 checks passed
@lehins lehins deleted the lehins/allow-deregistration-and-withdrawal-in-same-tx branch October 23, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants