Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: passive P2P enabled, ledger peers #4028

Closed
deepfire opened this issue Jun 9, 2022 · 4 comments
Closed

bench: passive P2P enabled, ledger peers #4028

deepfire opened this issue Jun 9, 2022 · 4 comments
Labels
benchmark peer2peer Issues / PRs related to peer-2-peer

Comments

@deepfire
Copy link
Contributor

deepfire commented Jun 9, 2022

@coot told us this is like #4027, but needs a >0 value for useLedgerAfterSlot:

EnableP2P: True
TestEnableDevelopmentNetworkProtocols: True
useLedgerAfterSlot: 1

This also, of course, needs the peers to be in the ledger state (so we need bake them into genesis).

@deepfire deepfire added peer2peer Issues / PRs related to peer-2-peer P2P benchmark labels Jun 9, 2022
@deepfire deepfire changed the title bench: P2P enabled, ledger peers bench: passive P2P enabled, ledger peers Jun 9, 2022
@deepfire
Copy link
Contributor Author

deepfire commented Jul 1, 2022

#4028 is a prerequisite.

@deepfire
Copy link
Contributor Author

#4234 enables ledger peer injection.

@coot
Copy link
Contributor

coot commented Aug 12, 2022

I'm actually not sure if using ledger peer in benchmarking is a good idea. It will increase uncertainty, and more randomness into the benchmarks. The nodes are making random decision who to promote to hot peers, churn, once an hour, removes 20% of least performing peers. Since you're executing this in a controlled environment (one data centre, right?) it will just add more randomness. Different benchmarks will not be comparable as they will use different topology, and it will be even harder to decide whether the new results are better or worse than previous ones.

@Jimbo4350
Copy link
Contributor

Closing this. If this is still relevant please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark peer2peer Issues / PRs related to peer-2-peer
Projects
None yet
Development

No branches or pull requests

3 participants