-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: passive P2P enabled, ledger peers #4028
Comments
#4028 is a prerequisite. |
#4234 enables ledger peer injection. |
I'm actually not sure if using ledger peer in benchmarking is a good idea. It will increase uncertainty, and more randomness into the benchmarks. The nodes are making random decision who to promote to hot peers, churn, once an hour, removes 20% of least performing peers. Since you're executing this in a controlled environment (one data centre, right?) it will just add more randomness. Different benchmarks will not be comparable as they will use different topology, and it will be even harder to decide whether the new results are better or worse than previous ones. |
Closing this. If this is still relevant please reopen. |
@coot told us this is like #4027, but needs a >0 value for
useLedgerAfterSlot
:This also, of course, needs the peers to be in the ledger state (so we need bake them into genesis).
The text was updated successfully, but these errors were encountered: