Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High memory usage when running query stake-snapshot and others. #4140

Closed
4 tasks done
Tracked by #4144
CarlosLopezDeLara opened this issue Jul 6, 2022 · 2 comments
Closed
4 tasks done
Tracked by #4144
Assignees
Labels
area: leadership-schedule bug Something isn't working enhancement New feature or request in-scope This item is being worked and will be part of an upcoming release priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn type: bug Something is not working user type: internal Created by an IOG employee

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Jul 6, 2022

Investigate. There might be some way to reduce this by returning results more eagerly. High memory usage when running


Reference issues:

#2717
#4128


Additional information

Screenshot_20220705_191852
Screenshot_20220705_192055


Acceptance Criteria

AC stake snapshot

  • Return the total active stake on the system and the pool stake for the last three stake snapshots
  • Do not download the entire ledger state to obtain the stake snapshots
  • Command takes less than 5s to return results on a machine that meets the required specs
  • Uses less than 12G of RAM

AC leadership schedule

  • Leadership schedule returns valid JSON to stdout and cbor to file
  • Running leadership-schedule takes less than 30 seconds
  • Uses less than 12G of RAM

AC pool-state

  • This command obsoletes pool-params query
  • Pool-params executes pool-state with a notification to the user about the new command
  • Pool-state returns a JSON of futurePoolParams, poolParams, and retiring
  • Runs in less than 5 seconds
  • Uses less than 12 GB

AC Ledger state

  • Keeps returning JSON to stdout
  • Uses less than 16 GB
@CarlosLopezDeLara CarlosLopezDeLara added bug Something isn't working enhancement New feature or request 1.35.1 Include in 1.35.1 labels Jul 6, 2022
@CarlosLopezDeLara CarlosLopezDeLara self-assigned this Jul 6, 2022
@CarlosLopezDeLara CarlosLopezDeLara added the priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn label Jul 6, 2022
@CarlosLopezDeLara CarlosLopezDeLara added 1.35.2 and removed 1.35.1 Include in 1.35.1 labels Jul 8, 2022
@CarlosLopezDeLara CarlosLopezDeLara added in-scope This item is being worked and will be part of an upcoming release and removed 1.35.2 labels Jul 22, 2022
@CarlosLopezDeLara CarlosLopezDeLara changed the title [BUG] High memory usage when running query stake-snapshot and others. High memory usage when running query stake-snapshot and others. Aug 17, 2022
@dorin100
Copy link

When we say in the Acceptance Criteria "uses less than X GB", I suppose this refers to the recommended specs, right? We are interested to make clear to the users what are the min specs they need in order to have these functionalities working.

"pool-state" is a new cli command?

@CarlosLopezDeLara
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: leadership-schedule bug Something isn't working enhancement New feature or request in-scope This item is being worked and will be part of an upcoming release priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn type: bug Something is not working user type: internal Created by an IOG employee
Projects
None yet
Development

No branches or pull requests

3 participants