New query pool-state command #4170
Merged
+140
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd and
JaredCorduan
as code owners
newhoggy
force-pushed
the
newhoggy/new-query-pool-state-command
branch
3 times, most recently
from
bc0e230
to
b4dcd7e
Compare
Jimbo4350
previously requested changes
Jul 12, 2022
newhoggy
force-pushed
the
newhoggy/new-query-pool-state-command
branch
from
b4dcd7e
to
80615c8
Compare
newhoggy
requested review from
deepfire,
denisshevchenko,
jutaro and
coot
as code owners
newhoggy
force-pushed
the
newhoggy/new-query-pool-state-command
branch
3 times, most recently
from
4507f38
to
8c1d6c9
Compare
4 tasks
It uses a lot less memory and CPU than the older command.
newhoggy
force-pushed
the
newhoggy/new-query-pool-state-command
branch
from
0df5d04
to
e60d113
Compare
Jimbo4350
reviewed
Jul 19, 2022
newhoggy
force-pushed
the
newhoggy/new-query-pool-state-command
branch
3 times, most recently
from
575d6cc
to
c6202f1
Compare
newhoggy
force-pushed
the
newhoggy/new-query-pool-state-command
branch
from
c6202f1
to
f0475c9
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 19, 2022
4170: New query pool-state command r=newhoggy a=newhoggy This obsoletes `query pool-params`. The command runs sub-second (rather than the `1m30s` the old command takes. It also allows multiple stake pools to be queried at a time. * Requires IntersectMBO/ouroboros-network#3890 * Requires IntersectMBO/cardano-ledger#2908 Co-authored-by: John Ky <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obsoletes
query pool-params. The command runs sub-second (rather than the1m30sthe old command takes. It also allows multiple stake pools to be queried at a time.