Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] - The new tracing system does not use severities for StartupTracer #4560

Closed
coot opened this issue Oct 25, 2022 · 0 comments · Fixed by #4561
Closed

[FR] - The new tracing system does not use severities for StartupTracer #4560

coot opened this issue Oct 25, 2022 · 0 comments · Fixed by #4561
Assignees
@coot
Labels
enhancement New feature or request

Comments

@coot
Copy link
Contributor

coot commented Oct 25, 2022

const Notice is used while we ought to have a proper severities like the old logging system does here.
@coot coot added the enhancement New feature or request label Oct 25, 2022
coot added a commit that referenced this issue Oct 25, 2022
@coot
Added severityStartupTracer
add1418 
Fixes #4560
@coot coot self-assigned this Oct 25, 2022
@coot coot mentioned this issue Oct 25, 2022
Merged
iohk-bors bot added a commit that referenced this issue Oct 29, 2022
@iohk-bors @coot
Merge #4561
521b64a 
4561: Trace changes r=Jimbo4350 a=coot

This PR contains various small changes to traces.

- Removed kind field from NodeTo{Node,Client}VersionData
- Fixed a typo
- Changed IP ToJSON instance
- Simplified ToJSON instance of LocalRootPeers
- Use Notice severity for NetworkConfigUpdate
- Added severityStartupTracer

Fixes #4560


Co-authored-by: Marcin Szamotulski <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in a2b5ecf Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coot coot

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trace changes IntersectMBO/cardano-node
1 participant
@coot