Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] - Replace all uses of Data.Map with the strict version #4648

Closed
erikd opened this issue Nov 18, 2022 · 0 comments · Fixed by #4675
Closed

[FR] - Replace all uses of Data.Map with the strict version #4648

erikd opened this issue Nov 18, 2022 · 0 comments · Fixed by #4675
Labels
comp: cardano-api type: enhancement An improvement on the existing functionality user type: internal Created by an IOG employee

Comments

@erikd
Copy link
Contributor

erikd commented Nov 18, 2022 •
edited
Loading

Internal/External
Internal

Describe the feature you'd like
There are numerous modules in the node code base that uses Data.Map when they should be using Data.Map.Strict (from containers) or Data.Strict.Map (from strict-containers).
@erikd erikd added the type: enhancement An improvement on the existing functionality label Nov 18, 2022
@Jimbo4350 Jimbo4350 mentioned this issue Nov 28, 2022
Merged
iohk-bors bot added a commit that referenced this issue Nov 29, 2022
@iohk-bors @Jimbo4350
Merge #4675
7f51ca6 
4675: Replace Data.Map with Data.Map.Strict r=Jimbo4350 a=Jimbo4350

Resolves #4648 

Co-authored-by: Jordan Millar <[email protected]>
@dorin100 dorin100 added user type: internal Created by an IOG employee comp: cardano-api labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: cardano-api type: enhancement An improvement on the existing functionality user type: internal Created by an IOG employee
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Data.Map with Data.Map.Strict IntersectMBO/cardano-node
2 participants
@erikd @dorin100