Accept either a pool verification key hash or file in StakeKeyDelegationCert command #1460
Conversation
intricate
requested review from
dcoutts,
erikd,
Jimbo4350,
mrBliss and
newhoggy
as code owners
| ) | ||
| where | ||
| spvkHash :: String -> Maybe (Hash StakePoolKey) | ||
| spvkHash = deserialiseFromRawBytesHex (AsHash AsStakePoolKey) . BSC.pack |
There was a problem hiding this comment.
We can do better than this now! We can use the bech32 support.
Which reminds me, Matthias had the excellent suggestion that where we accept bech32 we should to ease transitions and for compatibility, accept either bech32 or raw hex. I think we can do this straightforwardly in the api since our bech32 class is built on top of our raw serialisation class, so we could make a function to accept either.
So yes this is fine for now, but this should be an easy enhancement to add in. We could support file or bech32 in many places actually, various keys or key hashes. This draft CIP has the current list
cardano-foundation/CIPs#6
There was a problem hiding this comment.
Gotcha. So I'll merge this and then revise it later.
|
bors r+ |
1460: Accept either a pool verification key hash or file in StakeKeyDelegationCert command r=intricate a=intricate Closes #1377 Co-authored-by: Luke Nadur <[email protected]>
|
bors r- |
Canceled |
intricate
force-pushed
the
intricate/1377-pool-hash
branch
from
133cea0
to
751b610
Compare
|
bors r+ |
1460: Accept either a pool verification key hash or file in StakeKeyDelegationCert command r=intricate a=intricate Closes #1377 Co-authored-by: Luke Nadur <[email protected]>
|
bors r- |
Canceled |
intricate
force-pushed
the
intricate/1377-pool-hash
branch
from
751b610
to
43c013d
Compare
|
bors r+ |
Build succeeded |
Closes #1377