Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake related improvements #2672

Merged
merged 6 commits into from
May 7, 2021
Merged

Flake related improvements #2672

merged 6 commits into from
May 7, 2021

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented May 3, 2021

No description provided.

@jbgi jbgi added the WIP Work In Progress (cannot be merged yet) label May 3, 2021
@jbgi jbgi requested a review from a team May 3, 2021 18:58
@craigem
Copy link
Contributor

craigem commented May 4, 2021

It looks like customConfig is in the middle of being refactored - am I missing something or is this not ready for review?

(feel free to delete my commit, if needed)

@jbgi jbgi force-pushed the flakes-improvements branch 6 times, most recently from 1e2dd3f to e237c42 Compare May 4, 2021 20:00
@jbgi jbgi requested a review from craigem May 4, 2021 20:02
@jbgi jbgi removed the WIP Work In Progress (cannot be merged yet) label May 4, 2021
@jbgi jbgi force-pushed the flakes-improvements branch 2 times, most recently from e4cdf2b to 3a0b208 Compare May 6, 2021 15:40
Copy link
Contributor

@craigem craigem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

iohk-bors bot added a commit that referenced this pull request May 7, 2021
2672: Flake related improvements r=craigem a=jbgi



Co-authored-by: Jean-Baptiste Giraudeau <[email protected]>
Co-authored-by: Craige McWhirter <[email protected]>
@craigem
Copy link
Contributor

craigem commented May 7, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 7, 2021

@iohk-bors iohk-bors bot merged commit e5946a4 into master May 7, 2021
@iohk-bors iohk-bors bot deleted the flakes-improvements branch May 7, 2021 04:38
mkoura added a commit to mkoura/cardano-node-tests that referenced this pull request May 8, 2021
Fix `nix-shell` after changes introduced by IntersectMBO/cardano-node#2672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants