Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-2839 workbench: basic run management #2705

Merged
merged 5 commits into from
May 18, 2021
Merged

CAD-2839 workbench: basic run management #2705

merged 5 commits into from
May 18, 2021

Conversation

deepfire
Copy link
Contributor

  1. the run subdirectory now contains individual runs of the cluster
  2. massive refactors all over the place, in preparation to local-to-AWS-equivalence

TODO:

  1. fix stop-cluster

MarcFontaine
MarcFontaine approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcFontaine
Copy link
Contributor

bors +r

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 18, 2021

Did you mean "r+"?

@deepfire
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 18, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 2a6dbeb into master May 18, 2021
@iohk-bors iohk-bors bot deleted the cad-2839-equivalence branch May 18, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcFontaine MarcFontaine MarcFontaine approved these changes

@newhoggy newhoggy newhoggy approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepfire @MarcFontaine @newhoggy