Output as ledger compliant CDDL flag #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/output-cddl
branch
6 times, most recently
from
2a527e6
to
6f860f6
Compare
Jimbo4350
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
nc6 and
newhoggy
as code owners
newhoggy
reviewed
Jan 26, 2022
newhoggy
reviewed
Jan 26, 2022
newhoggy
reviewed
Jan 26, 2022
newhoggy
reviewed
Jan 26, 2022
newhoggy
reviewed
Jan 26, 2022
newhoggy
reviewed
Jan 26, 2022
newhoggy
reviewed
Jan 26, 2022
newhoggy
approved these changes
Jan 26, 2022
transactions that conform to the ledger's CDDL specification.
Jimbo4350
force-pushed
the
jordan/output-cddl
branch
from
6f860f6
to
b5fdfcf
Compare
|
bors r+ |
|
bors cancel |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 27, 2022
3505: Output as ledger compliant CDDL flag r=Jimbo4350 a=Jimbo4350 We implement an alternative `cardano-ledger` CDDL compliant serialization for the cli. The plan is to eventually deprecate the cli's intermediate format and to fully embrace the ledger's CDDL spec. There is now an optional `--cddl-format` flag in the `build` and `build-raw` commands that serialize the txbody as a **key** unwitnessed transaction. Any script witnesses specified at this stage are included in the witness set. Resolves #3370 Co-authored-by: Jordan Millar <[email protected]>
|
Canceled. |
Jimbo4350
force-pushed
the
jordan/output-cddl
branch
from
b5fdfcf
to
d910526
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement an alternative
cardano-ledgerCDDL compliant serialization for the cli. The plan is to eventually deprecate the cli's intermediate format and to fully embrace the ledger's CDDL spec.There is now an optional
--cddl-formatflag in thebuildandbuild-rawcommands that serialize the txbody as a key unwitnessed transaction. Any script witnesses specified at this stage are included in the witness set.Resolves #3370, #3544