-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vasil hardfork to cardano-api and cardano-cli #3765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
DavidEichmann,
dcoutts,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
April 4, 2022 16:45
Jimbo4350
changed the title
Add Vasil era to cardano-api
Add Vasil era to cardano-api and cardano-cli
Apr 4, 2022
Jimbo4350
force-pushed
the
jordan/add-babbage-era-to-cardano-api
branch
from
April 4, 2022 16:50
1f07aaa
to
101344d
Compare
JaredCorduan
reviewed
Apr 4, 2022
Unisay
reviewed
Apr 4, 2022
Jimbo4350
force-pushed
the
jordan/add-babbage-era-to-cardano-api
branch
from
April 5, 2022 13:01
101344d
to
8c3041f
Compare
newhoggy
approved these changes
Apr 5, 2022
Jimbo4350
requested review from
deepfire,
denisshevchenko,
jutaro,
MarcFontaine and
cleverca22
as code owners
April 5, 2022 17:01
MarcFontaine
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jimbo4350
force-pushed
the
jordan/add-babbage-era-to-cardano-api
branch
from
April 5, 2022 19:41
4cfc7f2
to
fdd304a
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 5, 2022
3765: Add Vasil era to cardano-api and cardano-cli r=Jimbo4350 a=Jimbo4350 This PR only introduces the era. It does not begin to integrate the new functionality exposed by `cardano-ledger`. Co-authored-by: Jordan Millar <[email protected]>
Build failed: |
one note about names: it is the Vasil hardfork, but the Babbage era 😬 |
Jimbo4350
changed the title
Add Vasil era to cardano-api and cardano-cli
Add Vasil hardfork to cardano-api and cardano-cli
Apr 5, 2022
bors r+ |
Merge conflict. |
Jimbo4350
force-pushed
the
jordan/add-babbage-era-to-cardano-api
branch
from
April 6, 2022 12:51
6f2de56
to
3f19137
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 6, 2022
3765: Add Vasil hardfork to cardano-api and cardano-cli r=Jimbo4350 a=Jimbo4350 This PR only introduces the era. It does not begin to integrate the new functionality exposed by `cardano-ledger`. Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: MarcFontaine <[email protected]>
Timed out. |
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only introduces the era. It does not begin to integrate the new functionality exposed by
cardano-ledger
.