Preserve the CBOR representation of scripts #4537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvikGalois
commented
Oct 18, 2022
LudvikGalois
force-pushed
the
ludvikgalois/preserve-cbor
branch
3 times, most recently
from
2848bc8
to
f792556
Compare
LudvikGalois
commented
Oct 24, 2022
LudvikGalois
force-pushed
the
ludvikgalois/preserve-cbor
branch
2 times, most recently
from
fb2529e
to
b2564d4
Compare
LudvikGalois
requested review from
deepfire,
denisshevchenko,
jutaro,
MarcFontaine,
mgmeier,
fmaste,
cleverca22,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
|
So this needs a rebase on
Linking to the issue in the description and elaborating on "Preserve the CBOR representation of scripts" in the commit message will save me having to ping you when the next release comes around and I have forgotten the specifics. |
LudvikGalois
force-pushed
the
ludvikgalois/preserve-cbor
branch
3 times, most recently
from
c598dea
to
8d3b75f
Compare
|
This PR is stale because it has been open 45 days with no activity. |
added 3 commits
December 28, 2022 12:20
In many places it's important to retain the original bytes that the user supplied so that the hash is what they expect. This is especially important for data sent as CBOR, since there's multiple way to represent identical arrays.
The `ScriptData` type can be used to build Plutus scripts, but if we store user supplied script data in it directly we will lose their original encoding of the data. `HashableScriptData` attempts to fix this issue by pairing `ScriptData` with the bytes used to represent it. In an attempt to minimise the breakage to code which depends on the API, functions which depended on the value of `ScriptData`, but doesn't need the original bytes now accept both `ScriptData` and `HashableScriptData` via the new `IsScriptData` class.
LudvikGalois
force-pushed
the
ludvikgalois/preserve-cbor
branch
from
8d3b75f
to
d92ab59
Compare
|
Subsumed by: #4886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4433