Export cardano-testnet API from Cardano.Testnet #4636

MarcFontaine · 2022-11-15T13:29:36Z

Resolves: #4602

MarcFontaine · 2022-11-15T13:30:09Z

Jimbo4350 · 2022-12-06T20:17:36Z

cardano-testnet/cardano-testnet.cabal

                        Util.Assert
                        Util.Base
                        Util.Ignore
                        Util.Process
                        Util.Runtime
+                        Parsers


I don't think Parsers needs to be exposed

Turned out it was needed for cabal build cardano-testnet:exe:cardano-testnet.
In any case, I renamed Parsers to Testnet.Parsers and kept it in the exported API.

Jimbo4350 · 2022-12-06T20:20:12Z

cardano-testnet/cardano-testnet.cabal

-                        Parsers.Shelley
-                        Parsers.Version
+  exposed-modules:      Cardano.Testnet
+                        Testnet.Byron
                        Util.Assert


Let's change Util.x to Testnet.Util.x. We will need to rename Testnet.Util to something else or put the functions/types in a suitable Testnet.Util.x module

Jimbo4350

LGTM! Just squash the commits

MarcFontaine · 2022-12-15T09:42:59Z

bors r+

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

MarcFontaine · 2022-12-15T09:43:37Z

bors r-

iohk-bors · 2022-12-15T09:43:39Z

Canceled.

MarcFontaine · 2022-12-15T15:26:32Z

bors r+

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

iohk-bors · 2022-12-15T17:49:07Z

Timed out.

MarcFontaine · 2022-12-16T08:53:03Z

bors r+

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

iohk-bors · 2022-12-16T10:59:46Z

Timed out.

MarcFontaine · 2022-12-22T12:53:18Z

bors r+

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

iohk-bors · 2022-12-22T15:23:21Z

Timed out.

MarcFontaine · 2023-01-03T15:42:47Z

bors r+

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

iohk-bors · 2023-01-03T15:47:59Z

Build failed:

ci/push

Jimbo4350 · 2023-01-03T17:12:01Z

cardano-testnet/src/Testnet/Parsers.hs

-module Parsers where
+module Testnet.Parsers
+(
+  commands


This does not follow the typical module export style. Please fix.

Jimbo4350

Good work 👍

MarcFontaine · 2023-01-12T16:58:44Z

bors r+

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

iohk-bors · 2023-01-12T17:07:09Z

Build failed:

ci/push

Jimbo4350 · 2023-01-12T17:50:55Z

cardano-testnet/src/Testnet/Parsers.hs

@@ -1,4 +1,6 @@
-module Parsers where
+module Testnet.Parsers


Jimbo4350 · 2023-01-12T17:52:00Z

cardano-testnet/test/Test/Cli/KesPeriodInfo.hs

                                [ "stake-address", "build"
                                , "--stake-verification-key-file", poolownerstakekey
                                , "--testnet-magic", show @Int testnetMagic
                                ]

-  poolowneraddresswstakecred <- H.execCli [ "address", "build"
+  poolowneraddresswstakecred <- execCli [ "address", "build"


List alignment

Jimbo4350 · 2023-01-12T17:52:16Z

cardano-testnet/test/Test/Cli/KesPeriodInfo.hs

@@ -144,20 +136,20 @@ hprop_kes_period_info = H.integration . H.runFinallies . H.workspace "chairman"
  poolcoldSkey <- H.note $ tempAbsPath </> "node-pool1/shelley/operator.skey"

  stakePoolId <- filter ( /= '\n') <$>
-                   H.execCli [ "stake-pool", "id"
+                   execCli [ "stake-pool", "id"


List alignment

Jimbo4350 · 2023-01-12T17:52:30Z

cardano-testnet/test/Test/Cli/KesPeriodInfo.hs

@@ -224,12 +216,12 @@ hprop_kes_period_info = H.integration . H.runFinallies . H.workspace "chairman"
  UTxO utxoWithStaking1 <- H.noteShowM $ H.jsonErrorFail $ J.fromJSON @(UTxO AlonzoEra) utxoWithStaking1Json
  txinForStakeReg <- H.noteShow =<< H.headM (Map.keys utxoWithStaking1)

-  void $ H.execCli [ "stake-address", "registration-certificate"
+  void $ execCli [ "stake-address", "registration-certificate"


List alignment

Jimbo4350 · 2023-01-12T17:52:39Z

cardano-testnet/test/Test/Cli/KesPeriodInfo.hs

@@ -241,7 +233,7 @@ hprop_kes_period_info = H.integration . H.runFinallies . H.workspace "chairman"
    , "--out-file", work </> "key-registration-cert.txbody"
    ]

-  void $ H.execCli [ "transaction", "sign"
+  void $ execCli [ "transaction", "sign"


List alignment

MarcFontaine requested review from dcoutts and Jimbo4350 as code owners November 15, 2022 13:29

MarcFontaine self-assigned this Nov 15, 2022

MarcFontaine requested review from erikd, newhoggy, JaredCorduan, LudvikGalois and CarlosLopezDeLara as code owners November 15, 2022 13:29

MarcFontaine mentioned this pull request Nov 15, 2022

Selectively expose modules from cardano-testnet #4602

Closed

MarcFontaine force-pushed the mafo/4602-testnet-api branch 2 times, most recently from b412d13 to ff2f3c4 Compare November 16, 2022 09:35

Jimbo4350 force-pushed the mafo/4602-testnet-api branch from ff2f3c4 to f853558 Compare November 16, 2022 12:35

MarcFontaine force-pushed the mafo/4602-testnet-api branch 2 times, most recently from 015f509 to 2f0f333 Compare November 16, 2022 14:56

Jimbo4350 requested changes Dec 6, 2022

View reviewed changes

MarcFontaine force-pushed the mafo/4602-testnet-api branch from 2f0f333 to 431d283 Compare December 7, 2022 15:32

MarcFontaine requested a review from Jimbo4350 December 7, 2022 15:33

MarcFontaine force-pushed the mafo/4602-testnet-api branch from 431d283 to 8a77b11 Compare December 14, 2022 14:10

Jimbo4350 approved these changes Dec 14, 2022

View reviewed changes

MarcFontaine force-pushed the mafo/4602-testnet-api branch from 8a77b11 to e702883 Compare December 15, 2022 09:42

iohk-bors bot added a commit that referenced this pull request Dec 15, 2022

Merge #4636

45e54b3

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

MarcFontaine force-pushed the mafo/4602-testnet-api branch from e702883 to bfcee66 Compare December 15, 2022 13:43

iohk-bors bot added a commit that referenced this pull request Dec 15, 2022

Merge #4636

fb67203

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

iohk-bors bot added a commit that referenced this pull request Dec 16, 2022

Merge #4636

13dd658

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

MarcFontaine force-pushed the mafo/4602-testnet-api branch from bfcee66 to fdb754d Compare December 22, 2022 12:31

iohk-bors bot added a commit that referenced this pull request Dec 22, 2022

Merge #4636

66fb980

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

MarcFontaine force-pushed the mafo/4602-testnet-api branch from fdb754d to 74f1f08 Compare January 3, 2023 15:42

iohk-bors bot added a commit that referenced this pull request Jan 3, 2023

Merge #4636

402525d

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

Jimbo4350 requested changes Jan 3, 2023

View reviewed changes

MarcFontaine force-pushed the mafo/4602-testnet-api branch from 74f1f08 to 15d1a4d Compare January 5, 2023 15:29

MarcFontaine requested a review from Jimbo4350 January 5, 2023 16:21

Jimbo4350 approved these changes Jan 11, 2023

View reviewed changes

export API from Cardano.Testnet

624c116

MarcFontaine force-pushed the mafo/4602-testnet-api branch from 15d1a4d to 624c116 Compare January 12, 2023 16:17

iohk-bors bot added a commit that referenced this pull request Jan 12, 2023

Merge #4636

0dc1d36

4636: Export cardano-testnet API from Cardano.Testnet r=MarcFontaine a=MarcFontaine Co-authored-by: MarcFontaine <[email protected]>

Jimbo4350 reviewed Jan 12, 2023

View reviewed changes

cardano-testnet/src/Testnet/Parsers.hs

@@ -1,4 +1,6 @@

module Parsers where

module Testnet.Parsers

Copy link

Contributor

Jimbo4350 Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Jimbo4350 reviewed Jan 12, 2023

View reviewed changes

Jimbo4350 merged commit ce5d3fa into master Jan 12, 2023

iohk-bors bot deleted the mafo/4602-testnet-api branch January 12, 2023 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export cardano-testnet API from Cardano.Testnet #4636

Export cardano-testnet API from Cardano.Testnet #4636

MarcFontaine commented Nov 15, 2022 •

edited by Jimbo4350

Loading

MarcFontaine commented Nov 15, 2022

Jimbo4350 Dec 6, 2022

MarcFontaine Dec 15, 2022

Jimbo4350 Dec 6, 2022

Jimbo4350 left a comment

MarcFontaine commented Dec 15, 2022

MarcFontaine commented Dec 15, 2022

iohk-bors bot commented Dec 15, 2022

MarcFontaine commented Dec 15, 2022

iohk-bors bot commented Dec 15, 2022

MarcFontaine commented Dec 16, 2022

iohk-bors bot commented Dec 16, 2022

MarcFontaine commented Dec 22, 2022

iohk-bors bot commented Dec 22, 2022

MarcFontaine commented Jan 3, 2023

iohk-bors bot commented Jan 3, 2023

Jimbo4350 Jan 3, 2023

Jimbo4350 left a comment

MarcFontaine commented Jan 12, 2023

iohk-bors bot commented Jan 12, 2023

Jimbo4350 Jan 12, 2023

Jimbo4350 Jan 12, 2023

Jimbo4350 Jan 12, 2023

Jimbo4350 Jan 12, 2023

Jimbo4350 Jan 12, 2023

Export cardano-testnet API from Cardano.Testnet #4636

Export cardano-testnet API from Cardano.Testnet #4636

Conversation

MarcFontaine commented Nov 15, 2022 • edited by Jimbo4350 Loading

MarcFontaine commented Nov 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jimbo4350 left a comment

Choose a reason for hiding this comment

MarcFontaine commented Dec 15, 2022

MarcFontaine commented Dec 15, 2022

iohk-bors bot commented Dec 15, 2022

MarcFontaine commented Dec 15, 2022

iohk-bors bot commented Dec 15, 2022

MarcFontaine commented Dec 16, 2022

iohk-bors bot commented Dec 16, 2022

MarcFontaine commented Dec 22, 2022

iohk-bors bot commented Dec 22, 2022

MarcFontaine commented Jan 3, 2023

iohk-bors bot commented Jan 3, 2023

Choose a reason for hiding this comment

Jimbo4350 left a comment

Choose a reason for hiding this comment

MarcFontaine commented Jan 12, 2023

iohk-bors bot commented Jan 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcFontaine commented Nov 15, 2022 •

edited by Jimbo4350

Loading