Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move style guide to wiki #4703

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy marked this pull request as ready for review December 11, 2022 07:29
coot
coot previously requested changes Dec 11, 2022
README.rst Outdated
Comment on lines 439 to 445
****
Style guide
****

The `style guide <https://github.com/input-output-hk/cardano-node/wiki/Style-guide>` for can be found in the wiki.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like that plutus, ouroboros-network, the future ouroboros-consensus and cardano-ledger are consistent in where style guide can be found.

  • plutus: STYLEGUIDE.docs
  • ouroboros-network: docs/StyleGuide.md
  • ouroboros-consensus (inside ouroboros-network repo): ouroboros-consensus/docs/StyleGuide.md
  • cardano-node: a wiki.

I would rather like to move the wiki page to STYLEGUIDE.md or at least put the link in the STYLEGUIDE.md document.

Copy link
Contributor Author

@newhoggy newhoggy Dec 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with docs/StyleGuide.md is we already have a doc directory (ie. no s). I'm not sure what the impact of renaming the directory is.

Would it suffice to rename STYLE.md to STYLEGUIDE.md?

Copy link
Contributor

@coot coot Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd use /STYLEGUIDE.md; I plan do the same in ouroboros-network repo once ouroboros-consensus* migrates to its own repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed.

README.rst Outdated
Style guide
****

The `style guide <https://github.com/input-output-hk/cardano-node/wiki/Style-guide>` for can be found in the wiki.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for cardano-node

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the reference to cardano-node.

@newhoggy newhoggy force-pushed the newhoggy/move-style-guide-to-wiki branch 2 times, most recently from 902938d to 7352a57 Compare December 13, 2022 22:34
@newhoggy newhoggy dismissed coot’s stale review December 15, 2022 00:02

comments addressed

@newhoggy newhoggy force-pushed the newhoggy/move-style-guide-to-wiki branch from 7352a57 to 6dad6ab Compare December 15, 2022 00:03
@Jimbo4350 Jimbo4350 merged commit bc2f2f5 into master Dec 20, 2022
@iohk-bors iohk-bors bot deleted the newhoggy/move-style-guide-to-wiki branch December 20, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants