Fix recursion in flake inputs. #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-eval-jobs seems to have trouble evaluating this flake. error: cannot update flake input 'cardano-node-workbench/membench' in pure mode Simplifying the recursion in the flake inputs seems to help. Fixes #4525
andreabedini
requested review from
a team,
deepfire,
mgmeier and
fmaste
as code owners
angerman
approved these changes
Feb 7, 2023
andreabedini
force-pushed
the
fix-flake-inputs-recursion
branch
from
975165c
to
a315a63
Compare
andreabedini
force-pushed
the
fix-flake-inputs-recursion
branch
from
a315a63
to
623c748
Compare
|
I think this is good to go. Only the non-required fail, which have been failing for a while, and should be broken out in a separate PR to fix. |
|
bors try |
tryBuild succeeded: |
Merged
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hydra-eval-jobs seems to have trouble evaluating this flake.
error: cannot update flake input 'cardano-node-workbench/membench' in pure mode
Simplifying the recursion in the flake inputs seems to help.
Fixes #4525