Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip hash metrics #4915

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Tip hash metrics #4915

merged 6 commits into from
Mar 2, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Feb 24, 2023

Salvaging this PR #2006

Related to #801

@newhoggy newhoggy force-pushed the newhoggy/tip-hash-metrics branch 8 times, most recently from ea6d92d to d7b25e6 Compare February 24, 2023 14:09
@intricate
Copy link
Contributor

Thanks 😁

@newhoggy newhoggy force-pushed the newhoggy/tip-hash-metrics branch 20 times, most recently from 2df3570 to 87bb984 Compare February 28, 2023 08:31
@newhoggy newhoggy marked this pull request as ready for review February 28, 2023 08:31
cardano-node/src/Cardano/Tracing/Tracers.hs Outdated Show resolved Hide resolved
@newhoggy
Copy link
Contributor Author

newhoggy commented Mar 1, 2023

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 1, 2023
4912: Add slotsInEpoch and slotsToEpochEnd to query tip command r=newhoggy a=newhoggy

Example output:

```
CARDANO_NODE_SOCKET_PATH=example/node-pool1/node.sock cardano-cli query tip --testnet-magic 42
{
    "block": 768,
    "epoch": 33,
    "era": "Alonzo",
    "hash": "4ca7fd3a9827e74f98e779a8ae333dc6fa3b69832cb11fdbab7af215eb68b1ee",
    "slot": 16814,
    "slotsInEpoch": 314,
    "slotsToEpochEnd": 186,
    "syncProgress": "100.00"
}
```

Resolves #3878


4915: Tip hash metrics r=newhoggy a=newhoggy

Salvaging this PR #2006

Related to #801


4922: Deploy Haddock for merge to master only r=newhoggy a=newhoggy

To merge changes from this PR #3012

Co-authored-by: John Ky <[email protected]>
Co-authored-by: Luke Nadur <[email protected]>
Co-authored-by: James Browning <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 1, 2023

This PR was included in a batch that timed out, it will be automatically retried

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You should be able to squash your commit into the first one without issue

cardano-node/src/Cardano/Tracing/Tracers.hs Outdated Show resolved Hide resolved
iohk-bors bot added a commit that referenced this pull request Mar 1, 2023
4915: Tip hash metrics r=newhoggy a=newhoggy

Salvaging this PR #2006

Related to #801


4918: Fix key non extended key for StakeExtendedVerificationKeyShelley_ed25519_bip32 envelope r=newhoggy a=newhoggy

* Fix key non extended key for `StakeExtendedVerificationKeyShelley_ed25519_bip32` envelope
* Add ability to generate golden files from test using `CREATE_GOLDEN_FILES=1`
* New `diffFileVsGoldenFile` function

Resolves #4914

4922: Deploy Haddock for merge to master only r=newhoggy a=newhoggy

To merge changes from this PR #3012

Co-authored-by: Luke Nadur <[email protected]>
Co-authored-by: John Ky <[email protected]>
Co-authored-by: James Browning <[email protected]>
@Jimbo4350
Copy link
Contributor

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 1, 2023

Canceled.

@newhoggy newhoggy requested a review from Jimbo4350 March 2, 2023 17:11
@newhoggy newhoggy dismissed Jimbo4350’s stale review March 2, 2023 17:11

Comments addressed

@newhoggy
Copy link
Contributor Author

newhoggy commented Mar 2, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 2, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 18d5ab4 into master Mar 2, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/tip-hash-metrics branch March 2, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants