Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of GitHub status notif related to nix builds #4930

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Mar 2, 2023

No description provided.

@jbgi jbgi requested review from a team, deepfire, mgmeier and fmaste as code owners March 2, 2023 14:53
@jbgi jbgi force-pushed the reduce-github-status-notif branch 4 times, most recently from 46f7e28 to c55ac8b Compare March 3, 2023 09:03
@jbgi jbgi force-pushed the reduce-github-status-notif branch 4 times, most recently from 0396dcf to b240e97 Compare March 3, 2023 10:24
@Jimbo4350 Jimbo4350 enabled auto-merge March 3, 2023 13:54
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Mar 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 3, 2023
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Mar 3, 2023
@Jimbo4350
Copy link
Contributor

Thanks @jbgi

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 3, 2023
@angerman angerman enabled auto-merge March 6, 2023 08:47
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. though I believe we might be able to drop bors soon, as node now uses merge-queues.

@angerman angerman added this pull request to the merge queue Mar 6, 2023
Merged via the queue into master with commit 385c247 Mar 6, 2023
@iohk-bors iohk-bors bot deleted the reduce-github-status-notif branch March 6, 2023 10:27
iohk-bors bot added a commit that referenced this pull request Mar 27, 2023
5023: fix CI not running on bors branches r=disassembler a=dermetfan

Looks like this was broken in #4930 as `prAndBorsIo` was added but not used.

Also removed `nix` from the task name. I do not see what purpose it has and it makes the names unnecessarily long. Also we happen to need the old names in #5018.

Co-authored-by: Robin Stumm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants