-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of GitHub status notif related to nix builds #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbgi
force-pushed
the
reduce-github-status-notif
branch
4 times, most recently
from
March 3, 2023 09:03
46f7e28
to
c55ac8b
Compare
jbgi
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
March 3, 2023 09:32
jbgi
force-pushed
the
reduce-github-status-notif
branch
4 times, most recently
from
March 3, 2023 10:24
0396dcf
to
b240e97
Compare
Jimbo4350
approved these changes
Mar 3, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Mar 3, 2023
Thanks @jbgi |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Mar 3, 2023
Signed-off-by: Moritz Angermann <[email protected]>
waiting for a better notif filtering mecanism. Signed-off-by: Moritz Angermann <[email protected]>
Signed-off-by: Moritz Angermann <[email protected]>
angerman
force-pushed
the
reduce-github-status-notif
branch
from
March 6, 2023 08:48
b240e97
to
05bbb49
Compare
angerman
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. though I believe we might be able to drop bors soon, as node now uses merge-queues.
iohk-bors bot
added a commit
that referenced
this pull request
Mar 27, 2023
5023: fix CI not running on bors branches r=disassembler a=dermetfan Looks like this was broken in #4930 as `prAndBorsIo` was added but not used. Also removed `nix` from the task name. I do not see what purpose it has and it makes the names unnecessarily long. Also we happen to need the old names in #5018. Co-authored-by: Robin Stumm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.