Backport #5050 & #5132 to `release/1.35` #5151

…raight-line-code-for-tx-commands Straight line code for tx commands

…grade-to-cabal-3.10.1.0 Upgrade to cabal-3.10.1.0

…ics-mapping Backward compatibility for Prometheus metrics names

…rdano-ping New cardano-cli ping command.

- makeByronTransactionBody guards against overflows in the transaction indices, but makeShelleyTransactionBody does not. - Add appropriate guards to makeShelleyTransactionBody.

I revised a bunch of things in CHaP and the constraints are not needed any more.

Split it into node-to-node and node-to-client. This is needed so that the log contains information whether the version numbers (now encoded as numbers) are node-to-node or node-to-client version.

Fixes input-output-hk/ouroboros-network#3691

The warning is not needed as of ouroboros-network#3859.

P2P is now an early release: we encourage to enable it on at most one of the relays (if one has more than one relay). We don't advise yet to use it on BP nodes.

…etwork-version-repr Use JSON instances for NodeToNodeVersion & NodeToClientVersion

…constraints Bump CHaP and remove most constraints from the cabal file

…-genesis workbench: Distribute genesis using an intermediate storage service

nix: switch to ghc 9.2.7

fix CI not running on bors branches

…fault-values Combinators for TxBodyContent and related types

…-enable-kes-period-info-test Re-enable kes-period-info test.

…l/txin-overflow Guard against overflows in Shelley TxIns

Use the wrapper functions in the Shelley testnet.

…appers Use Haskell variables for passing values.

…x-qKesKesKeyExpiry Fix qKesKesKeyExpiry to not always be null

using detailed schema.

for `ScriptDataNumber` constructor including numbers outside `maxBound @Word64`.

…riptDataSerialisation Script data serialisation

Cabal has a tendency to create more files appended with ~x if you run cabal update

…tra-ignores Ignore IntelliJ folder and cabal.project.local*

…mplify-implementation-of-executeQueryAnyMode-via-inlining Simplify implementation of executeQueryAnyMode

…quiringFailure

…move-unused-error-constructors Remove unused error constructors

…move-use-of-AcquireFailure-type Remove use of AcquireFailure type

bench: analysis improvements

Previously we gave up when the non-Ada part of a transaction wasn't balanced. We now balance the transaction and correctly update the fee accordingly (since the fee will be higher). We also return an error in the case where the is non-Ada change, but not at least minUTxO change (e.g. in the case where the Ada is already balanced). Resolves: IntersectMBO#3068

…s/autobalance-multiasset Auto-balance multiasset transactions

FIX: Typo

…ozen-callstack-for-checkTextEnvelopeFormat Frozen callstack for checkTextEnvelopeFormat function

…move-stake-address-option-from-stake-address-build-command Remove --stake-address option from stake-address build

…fine-functor-instance-for-FileError Define Functor instance for FileError

* writeByteStringFile * writeByteStringOutput * writeLazyByteStringFile * writeLazyByteStringOutput * writeTextFile * writeTextOutput

…m IO

…ardano.Api.SerialiseTextEnvelope has less IO code and can be freed from CPP

…nerPermissions for consistency

…orWritingWithOwnerPermission

* writeByteStringFileWithOwnerPermissions * writeTextFileWithOwnerPermissions

…ringFileWithOwnerPermissions and textEnvelopeToJSON instead

which also requires using github project (instead of hackage) for hls.

…cs/readme-build-instructions-improvements Small build docs improvements

…prove-roundtrip-functions-to-report-annotations-on-callsite Improve roundtrip functions to report annotations on callsite

…lit-serialisation-from-io Split serialisation from IO

…-vault Bench nomad sub-backends

This helps keep flake dependencies down & avoids having to go through a different team for changes to the scripts.

Commment what it's doing, make better use of filepath primitives, remove dependency on the text package, and use less golfy style.

TestEnableDevelopmentHardForkEras has been renamed to TestEnableDevelopmentProtVer. An error is thrown if TestEnableDevelopmentHardForkEras is used to avoid it silently being set to False. Closes IntersectMBO#4043

TestEnableDevelopmentNetworkProtocols has been renamed to ExperimentalProtocols. An error is thrown if TestEnableDevelopmentNetworkProtocols is used to avoid it silently being set to False.

…s/testenableadvertiseprotver Rename TestEnableDevelopmentHardForkEras and TestEnableDevelopmentNetworkProtocols

…-index-state Remove dup of index-state, no longer needed with latest haskell.nix

…x-hlint-warnings Fix hlint warnings

…w-genCardanoKeyWitness-function New genCardanoKeyWitness function

…bench-01 use TH-generated plutus scripts

…in name

…ages

…l chain filter-outs

workbench: updates

…move-unused-script Remove unused script

The function deserialiseFromRawBytes was changed from Maybe to Either SerialiseAsRawBytesError, but the error type was not exposed in the Cardano.API.

This makes it simple to re-use de/serialisation for new types with DerivingVia. It is extensively used inside cardano-api and hence provides a clear value to users of the SDK as well.

- I made an upstream PR for the `katip` issue, which got merged and released. - `ekg`, `ekg-json`, and `libsystemd-journal` are unmaintained, so I revised them in CHaP.

…onvert tests into property tests

…mplify-cddl-tests Simplify cddl tests

…even-more-stuff Remove last remaining allow-newers

…x-nightly-builds Fix nightly builds

…ds in generator

…lete-duplicate-packages-sort-packages-and-imports Delete duplicate packages sort packages and imports

…x-import-warning Fix import warning

…ovides them (IntersectMBO#5094) Force merge because it can only be tested on `master`.

…move-non-round-trippable-value-TxInsReferenceNone-for-babbage-onwards Remove non-round-trippable value TxInsReferenceNone for babbage onwards in generator

…iltering process

…ershipCheck

workbench: updates

…ve-parsers-to-reusable-location Move parsers to reusable location

…ature/deprecate-protocol-params-file IntersectMBO#5052 Remove reading protocol parameters from Shelley genesis file

* Start using newer version of libsystemd-journal from CHaP with fixed bounds

* Account for recent changes in consensus and ledger * Reduce a whole lot of duplication * Move all orphan instances for types defined in cardano-base and cardano-ledger into their own respective packages * Fix a bug where only metadata from TxAuxData was hashed upon transaction body creation with `createTransactionBody` * Change representation of CostModel. It is no longer a mapping from param name to values, but instead a list with values, where order of value dictates the mapping to param names of a plutus cost model for a particular plutus version * ToJSON instance for CostModel and consequently for ProtocolParameters will now produce a list of values instead of a key value mapping.

…te-ledger-conway Integrate latest ledger dependencies

… use more of in tests in the future and the function doesn't reduce the code by that much.

…es not yet behave era dependently

…place-roundtrip_CBOR-with-trippingCBOR Replace roundtripCBOR with trippingCbor

…e-using-raw-bytes-hex Expose UsingRawBytes et al types

…e-serialise-as-raw-bytes-error Expose SerialiseAsRawBytesError in Cardano.Api

…x-securityParam-and-epochLength Fix epochLength and securityParam to conform to the formula 10 * k / f

… identifying DReps for delegation

…nCertificate. This will make space for CIP-1926 which will introduce the StakeAddressDRepDelegationCertificate.

…egationCert

…-multi workbench: distributed nomad cloud

Update cardano-governance.md

…able

…enesis_future_offset

…er profile content

…e same value

…low-renamed-fields-to-exist-if-values-the-same Allow renamed fields to exist if values the same

Useful to have accessible from external modules that need to construct metadata values.

…alue It is quite common to need to construct long text or bytestring and, it is annoying to have to handle that at call-site every single time. Instead, we can provide smart constructors that takes care of splitting the text or byte string into reasonably-sized chunks. Note that we could also implement a version of those functions that is *more flexible* and only constructs chunks when needed; otherwise returning a plain MetaText or MetaBytes when they fit. For example, in CDDL, we would represent such a text string as: ``` arbitrary_text = text .size (0..64) / [ * text .size (0..64) ] ``` For the sake of keeping things simple however, those functions only implement the list variation.

This module is really meant to be driven by the cardano-cli or any client implementation that seeks to (re-)implement the SPO on-chain poll functionality.

This commit also introduces a new type-class 'AsTxMetadata' to hint to the fact that the chosen representation on-the-wire for those various types is a transaction metadata value. The serialization to CBOR becomes then straightforward once we've converted the type into a 'MetadataValue'. Similarly, the deserialization is made simpler by first deserializing an opaque 'MetadataValue', and then inspecting it to see if it has the expected shape.

These commands are pretty straightforward to write by leveraging the newly introduced Cardano.Api.Governance.Poll API. One may ask why use sometimes files, sometimes stderr and sometimes stdout in implementing those commands. As a rule of thumb: - stdout = relevant content that should be structured to be piped into other tools or send to files - stderr = debug information useful to communicate context and details to users A command-line that outputs interactive debug information on stdout is arguably doing something wrong; unless it's the main terminal output of the application (e.g. printing structured logs on stdout). Then, why stdout rather than a file? Because I find the UX a lot better that way. Command lines with too many params are arguably hard to process; and using file as the medium of exchanges makes it harder / prevent piping into other tools easily. When printing structured results on stdout, one can always redirect the output to a file should they want it; so IMO stdout should always be the default; and files used only when necessary. Here I am only using an output file in the case of create-poll as a "build artifact". It allows to produce two outputs with distinct purpose; the file is meant to be shared as file, and thus it makes sense to treat it as such from the CLI as well. It also makes it clearer for users (even though that's going to be only super users here) what is meant to be shared and what is metadata.

Mostly plumbing and parser implementation following what already exists.

This is meant as a way to assert on *expected failures*! Sadly, `try` or other exception handling mechanisms do not work inside of the `TestT` monad, so I had to extract and lift the error to be able to catch it and assert on it. Yet, I need to assert on failures and thus, failures should not crash the test early but be assertable as a possible execution outcome. There's maybe something more clever to do but I only had a day and a half to spend on all this so I'd rather "get it done".

…mands Fixture keys were generated using the command-line itself. The set of tests cover quite extensively the various commands, as well as a few 'negative' test scenarios. It is more complicated to cover the interactive part of the 'answer-poll' command through those tests; and this is therefore left as manual test. Instructions for executing the sequence will also be provided with the introduction of the commands (e.g. in the description of [PR#5050](IntersectMBO#5050).

… Witness} ``` roundtrip GovernancePoll CBOR: OK (0.09s) ✓ roundtrip GovernancePoll CBOR passed 100 tests. roundtrip GovernancePollAnswer CBOR: OK ✓ roundtrip GovernancePollAnswer CBOR passed 100 tests. roundtrip GovernancePollWitness CBOR: OK (0.01s) ✓ roundtrip GovernancePollWitness CBOR passed 100 tests. ```

``` Cardano.Api Test.Cardano.Api.Metadata valid & rountrip text chunks: OK (0.03s) ✓ valid & roundtrip text chunks passed 100 tests. Empty chunks 3% ▌··················· ✓ 1% Single chunks 26% █████▏·············· ✓ 5% Many chunks 71% ██████████████▏····· ✓ 25% valid & rountrip bytes chunks: OK ✓ valid & roundtrip bytes chunks passed 100 tests. Empty chunks 3% ▌··················· ✓ 1% Single chunks 55% ███████████········· ✓ 5% Many chunks 42% ████████▍··········· ✓ 25% ``` Turns out there were two issues: - Empty {text,byte}strings would generate a singleton chunk with an empty value; which is okay semantically but ugly; empty strings now generate an empty chunk. - Metadata values measure the length of UTF-8-encoded strings, which means we can't rely on default text functions to split a text string. This is likely an overkill in many situation in the context of PR#5050 since most questions / answers will be in plain english. However, we can now put emojis and crazy unicode characters in there without problems.

…x/check-for-missing-epochs-in-leadershipschedule Additional check for not-leader slots in LeadershipSchedule tests

…0094-on-chain-spo-polls Add new interim governance commands: {create, answer, verify}-poll

This commit fixes linux build failures

…d-fixes Master build failure fixes

…p-1694-make-space-for-drep-certificates CIP-1694 make space for DRep certificates

Parse JSON logs in hprop_shutdownOnSlotSynced.

…ET_PATH

…son-logs Default Cardano.Testnet to NodeLoggingFormatAsJson

…w-node-socket-path-cli-option New --socket-path cli option

…gonomic-directory-creation-code-in-tests Ergonomic directory creation code in tests

…ue undefined!

workbench: updates

…le-type-2 File type to track the content and direction of files

…w-mkExecConfig-function New mkExecConfig function

…date-hackage.nix Update hackage.nix

And also, remove the poll witnesses altogether from metadata. Since we'll now only rely on cold key signing, we can rely on the existing witness mechanism of transactions (combined with the 'required extra signatories' field). This slightly adjust the 'verifyPollAnswer' function to now work directly from a transaction and return the actual signatories. Consumers can then verify whether signatories meet their expected criteria.

As well as finalize the metadata extraction logic on the API's side. This is mostly the same thing as before, but it now takes a signed transaction file for verification instead of a standalone metadata. ``` ❯ cardano-cli governance verify-poll --poll-file polls/basic.json --tx-file verify/valid Found valid poll answer, signed by: [ "f8db28823f8ebd01a2d9e24efb2f0d18e387665770274513e370b5d5" ] ``` ``` ❯ cardano-cli -- governance verify-poll --poll-file polls/basic.json --tx-file verify/none Command failed: governance verify-poll Error: No answer found in the provided transaction's metadata. ``` ``` ❯ cardano-cli -- governance verify-poll --poll-file polls/basic.json --tx-file verify/malformed Command failed: governance verify-poll Error: Malformed metadata; couldn't deserialise answer: An error occured while decoding GovernancePollAnswer.2. Error: missing mandatory field ``` ``` ❯ cardano-cli -- governance verify-poll --poll-file polls/basic.json --tx-file verify/invalid Command failed: governance verify-poll Error: Invalid answer (42) not part of the poll. Accepted answers: 0 → yes 1 → no ``` ``` ❯ cardano-cli -- governance verify-poll --poll-file polls/basic.json --tx-file verify/mismatch Command failed: governance verify-poll Error: Answer's poll doesn't match provided poll (hash mismatch). ```

…nds.

- [x] Cover new error cases for 'verify' - [x] Create full-blown test transactions for 'verify' - [x] Slightly re-organised and re-structure data folder - [x] Remove now-unnecessary old files ``` ❯ tree cardano-cli/test/data/golden/shelley/governance . ├── answer │ └── basic.json ├── cold.sk ├── cold.vk ├── create │ ├── basic.json │ └── long-text.json ├── polls │ ├── basic.json │ └── long-text.json └── verify ├── invalid ├── malformed ├── mismatch ├── none └── valid ```

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport #5050 & #5132 to `release/1.35` #5151

Backport #5050 & #5132 to `release/1.35` #5151

Commits on Mar 20, 2023

Commits on Mar 21, 2023

Commits on Mar 22, 2023

Commits on Mar 24, 2023

Commits on Mar 26, 2023

Commits on Mar 27, 2023

Commits on Mar 28, 2023

Commits on Mar 29, 2023

Commits on Mar 30, 2023

Commits on Mar 31, 2023

Commits on Apr 1, 2023

Commits on Apr 2, 2023

Commits on Apr 4, 2023

Commits on Apr 5, 2023

Commits on Apr 6, 2023

Commits on Apr 7, 2023

Commits on Apr 8, 2023

Commits on Apr 11, 2023

Commits on Apr 12, 2023

Commits on Apr 13, 2023

Commits on Apr 14, 2023

Commits on Apr 15, 2023

Commits on Apr 17, 2023

Commits on Apr 18, 2023

Commits on Apr 19, 2023

Commits on Apr 20, 2023

Commits on Apr 25, 2023

Backport #5050 & #5132 to release/1.35 #5151

Backport #5050 & #5132 to release/1.35 #5151

Commits on Mar 20, 2023

Commits on Mar 21, 2023

Commits on Mar 22, 2023

Commits on Mar 24, 2023

Commits on Mar 26, 2023

Commits on Mar 27, 2023

Commits on Mar 28, 2023

Commits on Mar 29, 2023

Commits on Mar 30, 2023

Commits on Mar 31, 2023

Commits on Apr 1, 2023

Commits on Apr 2, 2023

Commits on Apr 4, 2023

Commits on Apr 5, 2023

Commits on Apr 6, 2023

Commits on Apr 7, 2023

Commits on Apr 8, 2023

Commits on Apr 11, 2023

Commits on Apr 12, 2023

Commits on Apr 13, 2023

Commits on Apr 14, 2023

Commits on Apr 15, 2023

Commits on Apr 17, 2023

Commits on Apr 18, 2023

Commits on Apr 19, 2023

Commits on Apr 20, 2023

Commits on Apr 25, 2023

Backport #5050 & #5132 to `release/1.35` #5151

Backport #5050 & #5132 to `release/1.35` #5151