Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Plutus v2 cost model decoding era dependent #5896

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 2, 2024

Description

Upgrade cardano-cli-9.2.0.0
Upgrade cardano-api-9.1.0.0

This PR makes reading of Alonzo genesis optionally era-sensitive. The era-sensitive part is the reading of Plutus V2 cost model in alonzo genesis. This should only matter for test environments, as the cost model is not present in mainnet genesis. The exact decoding behaviour is described here: https://github.com/IntersectMBO/cardano-api/pull/564/files#diff-b26996666f911332a0d29d7ee13063967982ca356bb0a0fe26dcde29aacc48ebR238

Related PRs:

Integrates fix for: IntersectMBO/cardano-cli#801

Workflow run against cardano-node-tests: https://github.com/IntersectMBO/cardano-node-tests/actions/runs/9956170300

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/make-plutus-v2-cost-model-era-dependent branch 7 times, most recently from 6f1e489 to e204dbd Compare July 11, 2024 10:34
@carbolymer carbolymer force-pushed the mgalazyn/fix/make-plutus-v2-cost-model-era-dependent branch 6 times, most recently from c75a987 to 51c8143 Compare July 22, 2024 14:55
@carbolymer carbolymer force-pushed the mgalazyn/fix/make-plutus-v2-cost-model-era-dependent branch 2 times, most recently from 10ebefa to 5eb2896 Compare July 23, 2024 06:45
@carbolymer carbolymer marked this pull request as ready for review July 23, 2024 09:21
@carbolymer carbolymer requested review from a team as code owners July 23, 2024 09:21
@carbolymer carbolymer changed the title Make plutus v2 cost model era dependent Make Plutus v2 cost model decoding era dependent Jul 23, 2024
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @carbolymer

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mkoura gave the thumbs up via slack. The comment needs to be elaborated a little more and indicate we are removing this after the hardfork.

@carbolymer carbolymer force-pushed the mgalazyn/fix/make-plutus-v2-cost-model-era-dependent branch from 5eb2896 to 13fe71f Compare July 24, 2024 12:31
@carbolymer carbolymer force-pushed the mgalazyn/fix/make-plutus-v2-cost-model-era-dependent branch from 13fe71f to 24b257c Compare July 24, 2024 14:34
@disassembler disassembler merged commit ac76baa into master Jul 24, 2024
15 of 16 checks passed
@disassembler disassembler deleted the mgalazyn/fix/make-plutus-v2-cost-model-era-dependent branch July 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants