Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supplemental datum script to use findDatum #6027

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Jimbo4350
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 requested review from a team as code owners October 30, 2024 15:45
@Jimbo4350 Jimbo4350 force-pushed the jordan/improve-supplemental-datum-script branch 2 times, most recently from d55da36 to 10cf941 Compare October 30, 2024 19:08
supplementalDatum :: V1.Datum
supplementalDatum = V1.Datum (PlutusTx.mkI 1)
{- On chain we are dealing with raw bytes. You can generate the datum hash from the cli via:
> cardano-cli transaction hash-script-data --script-data-value 1 :( 1 24-10-30 - 11:48:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> cardano-cli transaction hash-script-data --script-data-value 1 :( 1 24-10-30 - 11:48:29
> cardano-cli transaction hash-script-data --script-data-value 1

I think this bit isn't needed?

@Jimbo4350 Jimbo4350 force-pushed the jordan/improve-supplemental-datum-script branch from 10cf941 to 7717a69 Compare November 1, 2024 12:20
@Jimbo4350 Jimbo4350 merged commit bdcf9de into master Nov 1, 2024
18 of 25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/improve-supplemental-datum-script branch November 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants