[#1951] handle scripe based DReps on FE

CHANGELOG.md

@@ -19,6 +19,7 @@ changes.
 - Fix unwanted horizontal page scroll on Governance Actions page [Issue 1897](https://github.com/IntersectMBO/govtool/issues/1897)
 - Fix duplicate testIds for reference errors and hints in DRep metadata form [Issue 1965](https://github.com/IntersectMBO/govtool/issues/1965)
 - Eliminate duplicate DReps in the DRep Directory [Issue 2171](https://github.com/IntersectMBO/govtool/issues/2171)
+- Handle script based DReps [Issue 1951](https://github.com/IntersectMBO/govtool/issues/1951)
 
 ### Changed
 

govtool/frontend/src/components/organisms/DashboardCards/DelegateDashboardCard.tsx

@@ -13,7 +13,6 @@ import {
 } from "@molecules";
 import {
   correctAdaFormat,
-  formHexToBech32,
   getMetadataDataMissingStatusTranslation,
   openInNewTab,
 } from "@utils";
@@ -236,9 +235,7 @@ const getDisplayedDelegationId = ({
   ];
   if (delegateTo) {
     if (!restrictedNames.includes(delegateTo)) {
-      return delegateTo.includes("drep")
-        ? delegateTo
-        : formHexToBech32(delegateTo);
+      return delegateTo;
     }
     return undefined;
   }

govtool/frontend/src/context/wallet.tsx

@@ -657,8 +657,10 @@ const CardanoProvider = (props: Props) => {
           targetDRep = DRep.new_always_abstain();
         } else if (target === AutomatedVotingOptionDelegationId.no_confidence) {
           targetDRep = DRep.new_always_no_confidence();
-        } else if (target.includes("drep")) {
+        } else if (target.includes("drep1")) {
           targetDRep = DRep.new_key_hash(Ed25519KeyHash.from_bech32(target));
+        } else if (target.includes("drep_script1")) {
+          targetDRep = DRep.new_script_hash(Ed25519KeyHash.from_bech32(target));
         } else {
           targetDRep = DRep.new_key_hash(Ed25519KeyHash.from_hex(target));
         }

govtool/frontend/src/hooks/forms/index.ts

@@ -1,5 +1,4 @@
 export * from "./useCreateGovernanceActionForm";
-export * from "./useDelegateTodRepForm";
 export * from "./useEditDRepInfoForm";
 export * from "./useRegisterAsdRepForm";
 export * from "./useVoteActionForm";

govtool/frontend/src/models/api.ts

@@ -111,6 +111,7 @@ export enum DRepListSort {
 export type DrepDataDTO = {
   deposit: number;
   drepId: string;
+  isScriptBased: boolean;
   latestRegistrationDate: string;
   latestTxHash?: string;
   metadataHash?: string;
@@ -198,6 +199,7 @@ export type VotedProposal = {
 export type CurrentDelegation = {
   dRepHash: string | null;
   dRepView: string | null;
+  isDRepScriptBased: boolean;
   txHash: string | null;
 } | null;
 

govtool/frontend/src/pages/DRepDirectoryContent.tsx

@@ -13,7 +13,7 @@ import {
 } from "@hooks";
 import { DataActionsBar, EmptyStateDrepDirectory } from "@molecules";
 import { AutomatedVotingOptions, DRepCard } from "@organisms";
-import { correctAdaFormat, formHexToBech32, isSameDRep } from "@utils";
+import { correctAdaFormat, isSameDRep } from "@utils";
 import { DRepListSort, DRepStatus } from "@models";
 import {
   AutomatedVotingOptionCurrentDelegation,
@@ -59,9 +59,7 @@ export const DRepDirectoryContent: FC<DRepDirectoryContentProps> = ({
 
   const { dRepData: myDRepList } = useGetDRepListInfiniteQuery(
     {
-      searchPhrase: currentDelegation?.dRepView?.startsWith("drep")
-        ? currentDelegation.dRepView
-        : formHexToBech32(currentDelegation?.dRepHash ?? ""),
+      searchPhrase: currentDelegation?.dRepView ?? "",
     },
     { enabled: !!inProgressDelegation || !!currentDelegation },
   );

govtool/frontend/src/services/requests/getAdaHolderCurrentDelegation.ts

@@ -1,6 +1,7 @@
 import { CurrentDelegation } from "@models";
 
 import { API } from "../API";
+import { fixViewForScriptBasedDRep } from "@/utils";
 
 export const getAdaHolderCurrentDelegation = async ({
   stakeKey,
@@ -11,5 +12,16 @@ export const getAdaHolderCurrentDelegation = async ({
     `/ada-holder/get-current-delegation/${stakeKey}`,
   );
 
-  return response.data;
+  if (!response.data) return response.data;
+
+  // DBSync contains wrong representation of DRep view for script based DReps
+  const view = response.data.dRepView && fixViewForScriptBasedDRep(
+    response.data.dRepView,
+    response.data.isDRepScriptBased,
+  );
+
+  return {
+    ...response.data,
+    dRepView: view,
+  };
 };

govtool/frontend/src/services/requests/getDRepList.ts

@@ -1,3 +1,5 @@
+import { bech32 } from "bech32";
+
 import {
   type Infinite,
   type DRepStatus,
@@ -22,9 +24,19 @@ export const getDRepList = async ({
   filters = [],
   page = 0,
   pageSize = 10,
-  searchPhrase = "",
+  searchPhrase: rawSearchPhrase = "",
   status = [],
 }: GetDRepListArguments): Promise<Infinite<DRepData>> => {
+  // DBSync contains wrong representation of DRep view for script based DReps,
+  // but it's still used by BE
+  const searchPhrase = (() => {
+    if (rawSearchPhrase.startsWith("drep_script")) {
+      const { words } = bech32.decode(rawSearchPhrase);
+      return bech32.encode("drep", words);
+    }
+    return rawSearchPhrase;
+  })();
+
   const response = await API.get<Infinite<DrepDataDTO>>("/drep/list", {
     params: {
       page,
@@ -39,7 +51,8 @@ export const getDRepList = async ({
   const validatedResponse = {
     ...response.data,
     elements: await Promise.all(
-      response.data.elements.map(async (drep) => mapDtoToDrep(drep)),
+      response.data.elements
+      .map(async (drep) => mapDtoToDrep(drep)),
     ),
   };
 

govtool/frontend/src/utils/dRep.ts

@@ -1,3 +1,4 @@
+import { bech32 } from "bech32";
 import { DRepData } from "@/models";
 
 export const isSameDRep = (
@@ -9,3 +10,12 @@ export const isSameDRep = (
   }
   return drepId === dRepIdOrView || view === dRepIdOrView;
 };
+
+// DBSync contains wrong representation of DRep view for script based DReps
+export const fixViewForScriptBasedDRep = (view: string, isScriptBased: boolean) => {
+  if (isScriptBased && !view.startsWith("drep_script")) {
+    const { words } = bech32.decode(view);
+    return bech32.encode("drep_script", words);
+  }
+  return view;
+};

govtool/frontend/src/utils/getDRepID.ts

@@ -4,10 +4,16 @@ import { bech32 } from "bech32";
 
 import { CardanoApiWallet } from "@models";
 
-export const formHexToBech32 = (dRepID?: string) => {
+// TODO: How do we know if DRep is script based if we have no DRep data?
+export const formHexToBech32 = (dRepID?: string, isScript?: boolean) => {
   if (!dRepID) return;
   const words = bech32.toWords(Buffer.from(dRepID, "hex"));
-  const dRepIDBech32 = bech32.encode("drep", words);
+  let dRepIDBech32;
+  if (isScript) {
+    dRepIDBech32 = bech32.encode("drep_script", words);
+  } else {
+    dRepIDBech32 = bech32.encode("drep", words);
+  }
   return dRepIDBech32;
 };
 

govtool/frontend/src/utils/mapDtoToDrep.ts

@@ -1,5 +1,6 @@
 import { DRepData, DRepMetadata, DrepDataDTO } from "@/models";
 import { postValidate } from "@/services";
+import { fixViewForScriptBasedDRep } from "./dRep";
 
 export const mapDtoToDrep = async (dto: DrepDataDTO): Promise<DRepData> => {
   const emptyMetadata = {
@@ -15,6 +16,9 @@ export const mapDtoToDrep = async (dto: DrepDataDTO): Promise<DRepData> => {
     metadataValid: true,
   };
 
+  // DBSync contains wrong representation of DRep view for script based DReps
+  const view = fixViewForScriptBasedDRep(dto.view, dto.isScriptBased);
+
   if (dto.metadataHash && dto.url) {
     const validationResponse = await postValidate<DRepMetadata>({
       url: dto.url,
@@ -26,11 +30,13 @@ export const mapDtoToDrep = async (dto: DrepDataDTO): Promise<DRepData> => {
       ...validationResponse.metadata,
       metadataStatus: validationResponse.status || null,
       metadataValid: validationResponse.valid,
+      view,
     };
   }
 
   return {
     ...dto,
     ...emptyMetadata,
+    view,
   };
 };

govtool/frontend/src/utils/tests/dRep.test.ts

@@ -23,6 +23,7 @@ const EXAMPLE_DREP: DRepData = {
   motivations: null,
   qualifications: null,
   doNotList: false,
+  isScriptBased: false,
 };
 
 describe("isSameDRep function", () => {