Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong references object keys in Metadata #1169

Closed
MSzalowski opened this issue Jun 5, 2024 · 2 comments · Fixed by #1170
Closed

Wrong references object keys in Metadata #1169

MSzalowski opened this issue Jun 5, 2024 · 2 comments · Fixed by #1170

Comments

@MSzalowski
Copy link
Contributor

Context & versions

  • every env.

Steps to reproduce

  1. Go to any metadata creation tool such as governance action proposition.
  2. Fill in form values.
  3. Generate *.jsonld
  4. References object has value reference-label instead of label.

Actual behavior

References object has value reference-label instead of label

Expected behavior

Based on CIP-100 and CIP-108, references should have the property named label

@Sworzen1
Copy link
Contributor

Sworzen1 commented Jun 5, 2024

and uri instead of reference-uri ?

@pmbinapps
Copy link

NOT OK - retested on dev-sancho -still reference-label is used:

Image

  "@context": {
    "@language": "en-us",
    "CIP100": "https://github.com/cardano-foundation/CIPs/blob/master/CIP-0100/README.md#",
    "CIP108": "https://github.com/cardano-foundation/CIPs/blob/master/CIP-0108/README.md#",
    "hashAlgorithm": "CIP100:hashAlgorithm",
    "body": {
      "@id": "CIP108:body",
      "@context": {
        "references": {
          "@id": "CIP108:references",
          "@container": "@set",
          "@context": {
            "GovernanceMetadata": "CIP100:GovernanceMetadataReference",
            "Other": "CIP100:OtherReference",
            "label": "CIP100:reference-label",
            "uri": "CIP100:reference-uri",
            "referenceHash": {
              "@id": "CIP108:referenceHash",
              "@context": {
                "hashDigest": "CIP108:hashDigest",
                "hashAlgorithm": "CIP100:hashAlgorithm"
              }
            }
          }
        },
        "title": "CIP108:title",
        "abstract": "CIP108:abstract",
        "motivation": "CIP108:motivation",
        "rationale": "CIP108:rationale"
      }
    },
    "authors": {
      "@id": "CIP100:authors",
      "@container": "@set",
      "@context": {
        "name": "http://xmlns.com/foaf/0.1/name",
        "witness": {
          "@id": "CIP100:witness",
          "@context": {
            "witnessAlgorithm": "CIP100:witnessAlgorithm",
            "publicKey": "CIP100:publicKey",
            "signature": "CIP100:signature"
          }
        }
      }
    }
  },
  "authors": [],
  "hashAlgorithm": {
    "@value": "blake2b-256"
  },
  "body": {
    "abstract": {
      "@value": "test"
    },
    "motivation": {
      "@value": "test"
    },
    "rationale": {
      "@value": "test"
    },
    "references": [
      {
        "@type": "Other",
        "label": {
          "@value": "Label"
        },
        "uri": {
          "@value": "https://test.com"
        }
      }
    ],
    "title": {
      "@value": "test"
    }
  }
}```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants