-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Optimization, PDF Integration, Bug Fixes. #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ano-test-plans Refactor/tests to use cardano test plans
Enhance flexibility for local development
fix: External URL checks by mocking proposals
…m/IntersectMBO/govtool into 1142-metadata-validation-problems
…m/IntersectMBO/govtool into 1142-metadata-validation-problems
…-except-dev-env chore: disable pdf for the envs other than develop
…roblems Fetch proposal and drep metadata from metadata-validaiton-service
In the provided user story, the goal was to troubleshoot the failure in the Toggle Maintenance Page workflow by ensuring that all necessary environment variables are present. The acceptance criteria focused on identifying and setting the required environment variables for the workflow to run successfully. However, the commit candidate addresses this by removing the unnecessary creation and upload of the deployment config for the toggle-maintenance target. By simplifying the process and adjusting the workflow configuration, the changes aim to streamline the execution of the toggle maintenance page workflow and prevent potential errors caused by missing environment variables that are not really required.
…n-card fix/direct-voter-delegation-card
…t-section-of-drep-details fix: fix missing margin in drep details about section
…ailure-in-toggle-maintenance-page-workflow [#1195] Remove unnecessary deployment config dependancy
fix: fix vote context metadata creation
…ion-forum-enable-feature-flag chore: add proposal discussion forum feature flag
…ion-forum-enable-feature-flag chore: add missing variable to frontend make file
…ion-forum-enable-feature-flag chore: add missing arg in dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
[#1165] Align dRep directory tests with cardano-test-plans
[#1166] Enhance flexibility for local development
[#1167] Fix external URL checks by mocking proposals
[#1116] Refactor: Remove 'test.slow' and add comment explaining using test.slow
[#1169] Fix references body data
[#1170] Change test for generate metadata
Add
[#1164] Integrate pdf-ui package into govtool
[#1161] Increase max old space size for test job
[#1159] Add npmrc to every job
Fix
[#1161] Fix multiple wallet creation bug
[#1159] Fix abstain and support options visibility bug
[#1156] Fix GA submit where the date-time is not available
[#1168] Fix flaky tests
[#1161] Fix test ids
[#1169] Fix wrong references body data