Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Metadata anchor validation #1180

Closed
kneerose opened this issue Jun 6, 2024 · 4 comments · Fixed by #1226
Closed

[BUG] Metadata anchor validation #1180

kneerose opened this issue Jun 6, 2024 · 4 comments · Fixed by #1226
Labels
🐛 Bug Something isn't working

Comments

@kneerose
Copy link
Contributor

kneerose commented Jun 6, 2024

Context & versions

  • The current system allows users to register dReps, edit existing dReps, and submit (GA) proposals. During these processes, users can provide a metadata anchor link. However, the system does not validate the length of the URL within the link. This allows users to submit entries with URLs exceeding the expected character limit (greater than 128 bytes).

Steps to reproduce

  • Navigate to the dRep registration, edit dRep, or GA proposal submission page.
  • Fill out the required information.
  • In the metadata anchor field, enter a URL with a character count exceeding 128 bytes.
  • Observe that the submit button remains enabled, and no error message is displayed.

Actual behaviour

  • The system permits submission even if the URL in the metadata anchor field exceeds the character limit.

Screenshot from 2024-06-06 11-38-27

Expected behaviour

  • When a user enters a URL exceeding 128 bytes in the metadata anchor field, the system should:
    • Disable the submit button.
    • Display an error message like "Invalid URL: Character limit exceeded."

Report references

  • GA proposal submission : report
  • DRep registration : report
  • Edit registered dRep : report
@NabinKawan NabinKawan added the 🐛 Bug Something isn't working label Jun 6, 2024
@m-i-k-e
Copy link

m-i-k-e commented Jun 6, 2024

In my opinion, this is a P1.

@pmbinapps
Copy link

@Ryun1 @MSzalowski please confirm what max length should be use? previously 64 chars max were mentioned in User stories:

_Given that I am on the DRep registration page

If/when I have entered some information into the input box for metadata url, then it will be checked against the following criteria:
It must be <= 64 bytes in length_

@Ryun1
Copy link
Member

Ryun1 commented Jun 7, 2024

@pmbinapps

128 (bytes)

@pmbinapps
Copy link

OK NOW

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants