-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trim func, delegation, DRep name, GA state, URL validation, links; Fix metadata issues, DRep card, empty strings, URI validation; Update gov guide; Cleanup code #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-file-name-beyond-view-when-drep-title-is-long 1210-drep-registration-json-file-name-beyond-view-when-drep-title-is-long
…or-validation fix/1180-bug-metadata-anchor-validation
…-drep-registration-the-transaction-does-not-contain-a-vote-delegation-to-self fix/1211-when-submitting-a-drep-registration-the-transaction-does-not-contain-a-vote-delegation-to-self
chore/cleanup-code
…rd-drep_name-is-shown-instead-title-of-drep-passed-during-registration fix/1207-dashboard-drep-card-drep_name-is-shown-instead-title-of-drep-passed-during-registration
…e-actions-shared-state-to-be-passed-to-pillars feat: create governance actions shared state
…s-creation-guide docs: update buildSignSubmit parameters in gov action creation guide
…-data-validation fix: fix empty strings drep data validation
…for-tracking-registration-confirmation-in-drep-registration-confirmation-modal fix/1076-bug-missing-link-for-tracking-registration-confirmation-in-drep-registration-confirmation-modal
…e-to-every-deployment-workflow chore: add pdf enable toggle to every deployment workflow
…metadatas fix: fix uri validation of metadatas
Add trim func, DRep name, GA shared state, URL validation, PDF toggle; Fix metadata issues, DRep card; Update gov action guide.
pmbinapps
requested review from
placek,
adgud,
MSzalowski,
Sworzen1,
JanJaroszczak and
Ryun1
as code owners
June 11, 2024 16:52
MSzalowski
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
#1210 Add trim func to file length for editing DRep data and creating GA forms
#1211 Add delegation on self when registering a DRep
#1212 Add DRep name to dashboard delegation card
#1213 Create governance actions shared state
#1214 Add validation 128 bytes length for URL
#1215 Add link to register/edit DRep and create GA
Fix:
#1180 Fix bug in metadata anchor
#1207 Fix dashboard DRep card
#1216 Fix empty strings DRep data validation
#1217 Fix missing link
#1218 Fix URI validation of metadata
Change:
#1239 Update buildSignSubmit parameters in gov action creation guide
Remove:
#1228 Cleanup code