Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA - Treasury - unable to add Proposal with this type when bech32 receiving address is used #1231

Closed
pmbinapps opened this issue Jun 10, 2024 · 4 comments · Fixed by #1251
Closed
Labels
🐛 Bug Something isn't working

Comments

@pmbinapps
Copy link

pmbinapps commented Jun 10, 2024

Occurred being DRep and adding GA Treasury type with data like below:

Image

json: https://raw.githubusercontent.com/pmbinapps/vva/main/tmp/Treasury.jsonld

After long time GA is still not visible

Jam recording here

Screen recording:

Screen.Recording.2024-06-10.at.16.43.41.mov-shrunk.mp4
@pmbinapps pmbinapps added the 🐛 Bug Something isn't working label Jun 10, 2024
@pmbinapps
Copy link
Author

@Sworzen1 Works fine when stake adres is like: below

getRewardsAddress():
stake_test1uzcukm72stf8u0ppt3gu99gpvue3sqxw39yyclfvmflu8scjjracv

image

So it looks like stake adres validation is not blocking GA submission

@MSzalowski
Copy link
Contributor

We can valdiate only against the bech32, which the address you provide - is. That means that forms doesn't catch this as a wrong address, but the transaction with such address cannot be submitted on chain. That bug is P1, maybe even P2 as it reflects the normal network behaviour

@MSzalowski
Copy link
Contributor

Please have a look at this comment: #1187 (comment)

@pmbinapps pmbinapps changed the title GA - Treasury - unable to add Proposal with this type GA - Treasury - unable to add Proposal with this type when bech32 receiving address is used Jun 10, 2024
@Sworzen1 Sworzen1 removed their assignment Jun 12, 2024
@pmbinapps
Copy link
Author

OK NOW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
3 participants