Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance Actions and DRep Metadata fix #1215

Merged
merged 136 commits into from
Jun 10, 2024
Merged

Governance Actions and DRep Metadata fix #1215

merged 136 commits into from
Jun 10, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • governance actions and DRep metadata fix
  • deployment workflows and scripts update

Sworzen1 and others added 30 commits May 29, 2024 17:46
@Sworzen1
replace metadata validation service
8eca432
@Sworzen1
delete unnecessary util
b88aa2f
@Sworzen1
fix GA story
5bca641
@Sworzen1
fix type
13db99e
@Sworzen1
fix Voted GAs
103f040
@Sworzen1
take GA metadata from metadataStatus
bb14ce8
@Sworzen1
change name of const
2d98ec4
@Sworzen1
add translations for insufficient balance error modal
0ceb452
@Sworzen1
display modal on click propose GA on dashboard
60a80b7
@Sworzen1
display modal on submit GA
9dbf90f
@Sworzen1
change way to handle is delegation process
cd02e38
@Sworzen1
add is delegation for drep card
5490f3f
@Sworzen1
change way to handle is delegation process for automated voting options
f71d900
@Sworzen1
change props hierarchy in Button component
414dc45
@Sworzen1
add change for drep details
9aff427
@Sworzen1
fix drep card is loading
404c54d
@Sworzen1
add bio for drep registration
3a1302a
@NabinKawan
Align dRep directory tests with cardano-test-plans
e4e2a99
@kneerose @NabinKawan
Align drepRegistration and governance action tests with cardano-test-…
b74a075 
…plans
@NabinKawan
chore: Skip test 4J, and Rename 4D to 4C.3
aa7dccd
@NabinKawan
chore: Fix typo and Rename variables
eeb2244
@NabinKawan
Merge pull request #1165 from IntersectMBO/refactor/tests-to-use-card…
97fc12d 
…ano-test-plans

Refactor/tests to use cardano test plans
@NabinKawan
Enhance flexibility for local development
88cfa50
@NabinKawan
chore: Rename variables (temp. wallets count)
c2b3c7e
@NabinKawan
Merge pull request #1166 from IntersectMBO/enhancement/local-development
bd9ce30 
Enhance flexibility for local development
@NabinKawan
fix: External URL checks by mocking proposals
45515ac
@NabinKawan
chore: Remove unwanted log message
862c91f
@NabinKawan
Merge pull request #1167 from IntersectMBO/fix/external-url-checks
024a140 
fix: External URL checks by mocking proposals
@kneerose @NabinKawan
test: Remove test 4I as it cannot be performed on integration testing
d0f5f06
@kneerose @NabinKawan
fix: Flaky test 5E , 5I
ece88e4
MSzalowski and others added 20 commits June 7, 2024 12:01
@MSzalowski
fix: fix vote context metadata creation
e7310e9
@MSzalowski
Merge pull request #1194 from IntersectMBO/fix/missing-margin-in-abou…
47b10cc 
…t-section-of-drep-details

fix: fix missing margin in drep details about section
@MSzalowski
Merge pull request #1196 from IntersectMBO/fix/1195-troubleshooting-f…
adfdb74 
…ailure-in-toggle-maintenance-page-workflow

[#1195] Remove unnecessary deployment config dependancy
@MSzalowski
Merge pull request #1198 from IntersectMBO/fix/1142-metadata-creation
b339d8d 
fix: fix vote context metadata creation
@MSzalowski
chore: add proposal discussion forum feature flag
0a369ee
@MSzalowski
Merge pull request #1200 from IntersectMBO/chore/add-proposal-discuss…
378aa25 
…ion-forum-enable-feature-flag

chore: add proposal discussion forum feature flag
@MSzalowski
chore: add missing variable to frontend make file
dddf6ea
@MSzalowski
Merge pull request #1201 from IntersectMBO/chore/add-proposal-discuss…
90b7999 
…ion-forum-enable-feature-flag

chore: add missing variable to frontend make file
@MSzalowski
chore: add missing arg in dockerfile
e43a5f8
@MSzalowski
Merge pull request #1202 from IntersectMBO/chore/add-proposal-discuss…
dde0653 
…ion-forum-enable-feature-flag

chore: add missing arg in dockerfile
@pmbinapps
Merge pull request #1176 from IntersectMBO/develop
9b2593c 
Test Optimization, PDF Integration, Bug Fixes.
@MSzalowski
chore: bump pdf-ui package
6cf68c6
@MSzalowski
Merge pull request #955 from IntersectMBO/docs/262-govtool-architectu…
0af418d 
…re-documentation

[#262] GovTool architecture documentation
@MSzalowski
Merge pull request #1203 from IntersectMBO/chore/bump-pdf-ui-package-…
34c4c2e 
…version

chore: bump pdf-ui package
@MSzalowski
fix: fix unbound arg in frontend dockerfile
5eaa750
@MSzalowski
Merge pull request #1204 from IntersectMBO/fix/fix-unbound-arg-for-pdf
67883fd 
fix: fix unbound arg in frontend dockerfile
@pmbinapps
Merge pull request #1205 from IntersectMBO/develop
0d412ea 
Enhanced Documentation and Dockerfile Fix, pdf-ui Package Version Bumped, No Removals Detected.
@MSzalowski
chore: set defaults for PDF in yml deploy workflows
3743f2f
@MSzalowski
Merge pull request #1212 from IntersectMBO/chore/set-defaults-in-yml-…
87835b5 
…files

chore: set defaults for PDF in yml deploy workflows
@MSzalowski
Merge pull request #1214 from IntersectMBO/develop
b47440e 
test: #1212
@SandraRodziewicz
Copy link

SandraRodziewicz commented Jun 10, 2024 •
edited by pmbinapps
Loading

  1. DRep registration with metadata: correct
  • Check if metadata shows in DRep Directory correct
  1. Edit DRep correct
  2. Direct Voter registration - does the transaction go through correct
  3. Governance Actions submission:
  • Both: Info & Treasury correct
  • check if they appear in Gov Actions info type - correct !treasury type not shown
  1. Gov Actions submitted via GovTool should always pass validation (no data missing) correct
  2. Gov Actions not created via GovTool could be getting validation errors (data missing, data formatted incorrectly etc) correct

! One issue detected: Treasury type gov actions do not show in Governance Actions ---> explored - tracked here: #1231

@MSzalowski MSzalowski merged commit 22ba50b into staging Jun 10, 2024
2 of 6 checks passed
@pmbinapps pmbinapps mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbinapps pmbinapps pmbinapps approved these changes

@placek placek Awaiting requested review from placek placek is a code owner

@adgud adgud Awaiting requested review from adgud adgud is a code owner

@jankun4 jankun4 Awaiting requested review from jankun4 jankun4 is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MSzalowski @SandraRodziewicz @pmbinapps @Sworzen1 @NabinKawan @kneerose @placek @jankun4