Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] CIP-108 metadata - markdown text styling not shown #1244

Closed
Ryun1 opened this issue Jun 11, 2024 · 4 comments · Fixed by #1276 or #1311
Closed

[Bug] CIP-108 metadata - markdown text styling not shown #1244

Ryun1 opened this issue Jun 11, 2024 · 4 comments · Fixed by #1276 or #1311
Labels
🐛 Bug Something isn't working

Comments

@Ryun1
Copy link
Member

Ryun1 commented Jun 11, 2024

Context & versions

  • CIP-108 allows for metadata fields to contain basic markdown syntax, see here
  • Currently GovTool does not render this correctly

Steps to reproduce

  • Submit a governance action with markdown text styling supplied in a metadata field

Actual behavior

  • Markdown text styling is not rendered

Expected behavior

  • Markdown text styling is rendered

see here

image
@Ryun1 Ryun1 added the 🐛 Bug Something isn't working label Jun 11, 2024
@Ryun1 Ryun1 changed the title [Bug] CIP-108 metadata - markdown formatting not shown [Bug] CIP-108 metadata - markdown text styling not shown Jun 11, 2024
@MSzalowski MSzalowski self-assigned this Jun 12, 2024
@Sworzen1 Sworzen1 assigned Sworzen1 and unassigned MSzalowski Jun 13, 2024
Sworzen1 added a commit that referenced this issue Jun 13, 2024
@Sworzen1
#1244 add markdown element
b6f9598
@Sworzen1 Sworzen1 mentioned this issue Jun 13, 2024
Merged
5 tasks
@Sworzen1 Sworzen1 linked a pull request Jun 13, 2024 that will close this issue
fix/1244-bug-cip-108-metadata-markdown-text-styling-not-shown #1276
Merged
5 tasks
@MSzalowski MSzalowski assigned pmbinapps and unassigned Sworzen1 Jun 13, 2024
@pmbinapps
Copy link

@Sworzen1 just made try on dev, and I can not see any rendering of Markdown eg. on: https://dev-sanchonet.govtool.byron.network/connected/governance_actions/055202ee88529fdbc5bd85ef80a6cb38265ac744eee22926b375ab72a9dd182d#0

Could you take if this is working?

Image

@Sworzen1
Copy link
Contributor

Sworzen1 commented Jun 14, 2024 •
edited
Loading

I've merged it now, I have no idea why you tested it before merging.

@pmbinapps pmbinapps mentioned this issue Jun 14, 2024
Merged
@pmbinapps
Copy link

pmbinapps commented Jun 14, 2024 •
edited
Loading

OK - markdown supported:

Image

NOT OK - styled text is not fitting GA Details view

TBC: font is not Arial - like

Content should like like in this viewer, with reversed colors:

Image

@pmbinapps pmbinapps assigned Sworzen1 and unassigned pmbinapps Jun 14, 2024
MSzalowski added a commit that referenced this issue Jun 17, 2024
@MSzalowski
fix(#1244): fix direction on the governance actions
d29d19b
@MSzalowski MSzalowski assigned MSzalowski and unassigned Sworzen1 Jun 17, 2024
MSzalowski added a commit that referenced this issue Jun 17, 2024
@MSzalowski
fix(#1244): fix direction on the governance actions
d8aedbf
@MSzalowski MSzalowski mentioned this issue Jun 17, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Jun 17, 2024 that will close this issue
fix(#1244): fix direction on the governance actions #1311
Merged
5 tasks
MSzalowski added a commit that referenced this issue Jun 17, 2024
@MSzalowski
Merge pull request #1311 from IntersectMBO/fix/1244-bug-cip-108-wrong…
3a140e3 
…-display-order

fix(#1244): fix direction on the governance actions
MSzalowski added a commit that referenced this issue Jun 18, 2024
@MSzalowski
fix(#1244): Fix styling of the markdowns on the slider cards
566b057
@MSzalowski MSzalowski mentioned this issue Jun 18, 2024
Merged
5 tasks
MSzalowski added a commit that referenced this issue Jun 18, 2024
@MSzalowski
Merge pull request #1315 from IntersectMBO/fix/1244-bug-cip-108-wrong…
c9b0f69 
…-display-order

fix(#1244): Fix styling of the markdowns on the slider cards
@MSzalowski MSzalowski removed their assignment Jun 18, 2024
@MSzalowski MSzalowski mentioned this issue Jun 18, 2024
Merged
@MSzalowski MSzalowski mentioned this issue Jun 18, 2024
Merged
@pmbinapps
Copy link

OK NOW
https://test-sanchonet.govtool.byron.network/connected/governance_actions/e77b011c7b834b3e87eb91ab5257158a75448765fd981036f66319edce93b953#0

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
Govtool all
Status: Done
Milestone
No milestone
4 participants
@MSzalowski @Ryun1 @Sworzen1 @pmbinapps