Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Hard-Fork Initiation Governance Actions #1600

Closed
m-i-k-e opened this issue Jul 22, 2024 · 6 comments · Fixed by #1802
Closed

Rendering Hard-Fork Initiation Governance Actions #1600

m-i-k-e opened this issue Jul 22, 2024 · 6 comments · Fixed by #1802

Comments

@m-i-k-e
Copy link

m-i-k-e commented Jul 22, 2024

What?

  • GovTool should show voters the on-chain details for Hard-Fork Initiation Governance Actions
  • Showing users the proposed new protocol version.

Why?

  • This is important information that will help inform the voters
  • Hardfork initiations are available in the bootstrapping phase

How?

  • @m-i-k-e and team design how this could be rendered
  • GovTool BE API adjusted to provide this information
  • GovTool FE adjusted to render this new information

User Story

Title: Render all relevant all on-chain details of hard-fork initiations.

User Story: As a DRep, I want to be able to see all the relevant on-chain information for protocol parameter changes, including what parameters are being changed from what current value to the new proposed value.

Acceptance Criteria:

  • Given that I am a DRep.
  • When I view a hard-fork initiation in GovTool.
  • Then I should see all relevant on-chain details, including:
    • The proposed next major and minor protocol version
    • Their current protocol major and minor versions.
@m-i-k-e m-i-k-e changed the title "Hard-fork initiation" Discovery Hard-fork initiation Discovery Jul 30, 2024
@Ryun1 Ryun1 changed the title Hard-fork initiation Discovery Discovery - Rendering Hard Fork Initation Governance Actions Aug 5, 2024
@Ryun1 Ryun1 changed the title Discovery - Rendering Hard Fork Initation Governance Actions Discovery - Rendering Hard-Fork Initiation Governance Actions Aug 5, 2024
@Ryun1
Copy link
Member

Ryun1 commented Aug 5, 2024

What is this action all about?

  • Triggers a non-backwards compatible upgrade of the network; requires a prior software upgrade (upgrading node software versions)
  • Voted on by DReps, CC and SPOs
  • Available within the bootstrapping phase (will be used to exit the bootstrapping phase)

What are the on-chain details?

  • governance action ID of the previous hardfork initiation to be enacted (this isn't super important, but shows users how hard-forks can be chained together)
  • the next major and minor protocol versions

For example;

The hard-fork governance action for Chang #2 could look like

  • prev governance action ID = fc0386f81025d66fc448d4f0aa3ca6c1eeae95fe88e3b10244bacc126bbeb007#0
  • next protocol version (major.minor) = 10.0

What is other contextual information that might be nice?

  • the current protocol version

@Ryun1
Copy link
Member

Ryun1 commented Aug 6, 2024

Next step;

  • wireframes by Friday

cc @bosko-m

@Ryun1 Ryun1 changed the title Discovery - Rendering Hard-Fork Initiation Governance Actions Rendering Hard-Fork Initiation Governance Actions Aug 8, 2024
@m-i-k-e
Copy link
Author

m-i-k-e commented Aug 9, 2024

Wireframe to discuss:
hard fork

@Ryun1
Copy link
Member

Ryun1 commented Aug 9, 2024

@m-i-k-e
oo! this looks nice

I would rename Parameter label on the tab to details or something similar
to avoid confusion with protocol parameters

@m-i-k-e
Copy link
Author

m-i-k-e commented Aug 9, 2024

Good call!
hard fork

@m-i-k-e
Copy link
Author

m-i-k-e commented Aug 16, 2024

MSzalowski added a commit that referenced this issue Aug 23, 2024
…ork-initiation-governance-actions-prev-gov-action

feat(#1600): add support for previous governance action data
MSzalowski added a commit that referenced this issue Aug 23, 2024
…ion-details

[#1600] display hard fork initiation governance action details
MSzalowski added a commit that referenced this issue Aug 26, 2024
…on-details

[#1600] hide hardfork initiation details outside details tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment