Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 /api/drep/info/{drepId} - Missing off chain DRep metadata #1856

Closed
MSzalowski opened this issue Aug 28, 2024 · 7 comments
Closed

🐛 /api/drep/info/{drepId} - Missing off chain DRep metadata #1856

MSzalowski opened this issue Aug 28, 2024 · 7 comments
Assignees
Labels
🐛 Bug Something isn't working

Comments

@MSzalowski
Copy link
Contributor

MSzalowski commented Aug 28, 2024

Area

Domain

sanchogov.tools

Which wallet were you using?

Not wallet related

Context

Fetch DRep info of any DRep that has been registered with CIP-119 compliant metadata.

Steps to reproduce

  1. Register as a DRep providing all the metadata
  2. Wait until transaction finishes
  3. Check DRep details and provided under /api/drep/info response

Actual behavior

None of the CIP-119 metadata is provided

Expected behavior

off_chain_vote_drep_data should be populated with data and provided under /ap/drep/info response

(at this moment not sure whether it is db-sync related issue or wrong CIP-119 metadata generation by GovTool itself)

@MSzalowski MSzalowski added the 🐛 Bug Something isn't working label Aug 28, 2024
@vpaunovic
Copy link

@Ryun1 @bosko-m This should not be related to Proposal Pillar I think :)

@MSzalowski
Copy link
Contributor Author

That is definitely not a proposal pillar, I must have added that mistakenly

@vpaunovic
Copy link

@MSzalowski Github actions bot added it somehow

@Ryun1
Copy link
Member

Ryun1 commented Aug 28, 2024

@MSzalowski Github actions bot added it somehow

Damn who wrote that crappy bot?! haha

@MSzalowski
Copy link
Contributor Author

It could be me setting that pillar, bot is great 🫡

@bosko-m
Copy link
Contributor

bosko-m commented Aug 29, 2024

@MSzalowski @Ryun1 Moving to a milestone post bootstrap release.

@jdyczka
Copy link
Contributor

jdyczka commented Sep 25, 2024

@bosko-m For some DReps I'm getting this error from dbsync

Error Offchain Voting Anchor: JSON decode error from when fetching metadata from Just https://metadata-govtool.cardanoapi.io/data/Hulda resulted in : \"Error in $['@context']: key \\\"@language\\\" not found\"

CIP-100 states that it SHOULD be required, not MUST

The @context field SHOULD specify a @language property, which is an ISO 639-1 language string, to define a default language for the whole document

Previously we haven't been adding the @language field, so for dbSync to successfully validate DReps created by GovTool, either dbSync would have to accept metadata with no @language key or users would have to re-generate the metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants