Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BT] GA - Missing info icon next to the GA type (Already assigned) #464

Closed
pmbinapps opened this issue Mar 13, 2024 · 6 comments · Fixed by #745
Closed

[BT] GA - Missing info icon next to the GA type (Already assigned) #464

pmbinapps opened this issue Mar 13, 2024 · 6 comments · Fixed by #745
Labels
🐛 Bug Something isn't working

Comments

@pmbinapps
Copy link

Create after test of #358:

Found issue:
NOT OK: Each field should have a link to info via info icon next to the type.

#358 (comment)

Image

@l-br1 l-br1 added the 🐛 Bug Something isn't working label Apr 8, 2024
@l-br1
Copy link

l-br1 commented Apr 8, 2024

take content from 1694

@MSzalowski
Copy link
Contributor

MSzalowski commented Apr 9, 2024

@m-i-k-e Should it be the link or a tooltip?

@m-i-k-e
Copy link

m-i-k-e commented Apr 10, 2024

These will be tooltips. I'm asking @gypsy to do these in a Figma branch. However, he is currently not able to access the repo, so first we need to fix his access.

@pmbinapps pmbinapps changed the title GA - Missing info icon next to the GA type [BT] GA - Missing info icon next to the GA type (Already assigned) Apr 10, 2024
@m-i-k-e
Copy link

m-i-k-e commented Apr 10, 2024

Here's the table from the CIP: Please use these for tooltips.

  1. Motion of no-confidence A motion to create a state of no-confidence in the current constitutional committee

  2. New constitutional committee and/or threshold and/or terms Changes to the members of the constitutional committee and/or to its signature threshold and/or terms

  3. Update to the Constitution or proposal policy A modification to the Constitution or proposal policy, recorded as on-chain hashes

  4. Hard-Fork Initiation Triggers a non-backwards compatible upgrade of the network; requires a prior software upgrade

  5. Protocol Parameter Changes Any change to one or more updatable protocol parameters, excluding changes to major protocol versions ("hard forks")

  6. Treasury Withdrawals Withdrawals from the treasury

  7. Info An action that has no effect on-chain, other than an on-chain record

@MSzalowski MSzalowski assigned Sworzen1 and unassigned m-i-k-e Apr 16, 2024
Sworzen1 added a commit that referenced this issue Apr 16, 2024
@Sworzen1 Sworzen1 linked a pull request Apr 16, 2024 that will close this issue
5 tasks
@pmbinapps
Copy link
Author

OK NOW:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants