Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint and type errors in frontend package #514

Closed
MSzalowski opened this issue Mar 20, 2024 · 1 comment · Fixed by #533
Closed

Fix eslint and type errors in frontend package #514

MSzalowski opened this issue Mar 20, 2024 · 1 comment · Fixed by #533
Assignees
Labels

Comments

@MSzalowski
Copy link
Contributor

Due to the introduction of #511 eslint and tsc throws errors.

Result of lint execution:

✖ 672 problems (644 errors, 28 warnings)
  6 errors and 0 warnings potentially fixable with the `--fix` option.

Result of tsc execution:

Found 41 errors in 10 files.

DoD

All of the above should return no errors.

@MSzalowski MSzalowski added this to the Tech debt milestone Mar 20, 2024
@MSzalowski MSzalowski self-assigned this Mar 20, 2024
MSzalowski added a commit that referenced this issue Mar 21, 2024
MSzalowski added a commit that referenced this issue Mar 21, 2024
MSzalowski added a commit that referenced this issue Mar 21, 2024
@MSzalowski MSzalowski linked a pull request Mar 21, 2024 that will close this issue
5 tasks
MSzalowski added a commit that referenced this issue Mar 21, 2024
MSzalowski added a commit that referenced this issue Mar 22, 2024
…pe-errors-in-frontend-package

[#514] chore: fix eslint and typescript errors
@pmbinapps
Copy link

OK NOW - There are no errors.

Still some warnings that notifies users of the deprecation of Node.js 16 actions in GitHub actions. It advises updating to Node.js 20, specifically mentioning the actions/cache@v2 action. Additionally, it warns that actions currently using Node.js 12 will be forced to run on Node.js 16, with a link provided for further information.

Setting Ready for Stage - as above are not breaking any functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants