Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endless spinner on a dashboard #539

Closed
MSzalowski opened this issue Mar 24, 2024 · 3 comments · Fixed by #540
Closed

Endless spinner on a dashboard #539

MSzalowski opened this issue Mar 24, 2024 · 3 comments · Fixed by #540
Labels
🐛 Bug Something isn't working 🖥 Frontend Frontend related

Comments

@MSzalowski
Copy link
Contributor

Context & versions

Dashboard incorrectly reacts to isEnableLoading property that causes the endless spinner

Steps to reproduce

  1. Fetch repository
  2. git switch develop
  3. yarn or npm install
  4. yarn dev od npm run dev
  5. Open dashboard

Actual behavior

Endless spinner

Expected behavior

Spinner ends as soon as DRep or Sole Voter data is loaded.
@MSzalowski MSzalowski added 🐛 Bug Something isn't working 🖥 Frontend Frontend related labels Mar 24, 2024
@MSzalowski MSzalowski self-assigned this Mar 24, 2024
MSzalowski added a commit that referenced this issue Mar 24, 2024
@MSzalowski
[#539] fix: endless spinner on a dashbord
2f3d052
@MSzalowski MSzalowski mentioned this issue Mar 24, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Mar 24, 2024 that will close this issue
[#539] fix: endless spinner on a dashbord #540
Merged
5 tasks
MSzalowski added a commit that referenced this issue Mar 24, 2024
@MSzalowski
Merge pull request #540 from IntersectMBO/fix/539-endless-spinner-on-…
d70e867 
…a-dashboard

[#539] fix: endless spinner on a dashbord
@pmbinapps pmbinapps mentioned this issue Mar 25, 2024
Merged
@pmbinapps
Copy link

No such effect on test-sancho.
Setting Ready to Stage.

@pmbinapps pmbinapps self-assigned this Mar 25, 2024
@pmbinapps
Copy link

Occurred again after Retire:

Image

@pmbinapps pmbinapps mentioned this issue Apr 4, 2024
Merged
@bosko-m
Copy link
Contributor

bosko-m commented May 22, 2024

Changing this to the last known status before the migration to this project. (In Staging)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working 🖥 Frontend Frontend related
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#539] fix: endless spinner on a dashbord IntersectMBO/govtool
3 participants
@MSzalowski @pmbinapps @bosko-m