Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA Search - Voted on - Add search functionality #674

Closed
MSzalowski opened this issue Apr 9, 2024 · 3 comments · Fixed by #735
Closed

GA Search - Voted on - Add search functionality #674

MSzalowski opened this issue Apr 9, 2024 · 3 comments · Fixed by #735
Labels
🖥 Frontend Frontend related

Comments

@MSzalowski
Copy link
Contributor

Why

Voted on tab uses data from GET /drep/getVotes/{drepId} which should include the search parameters.
That task should provide integration with such params to allow searching for the voted on actions.

What

Integrate the search params of /drep/getVotes/{drepId} endpoint.

How

Use the same logic as for /proposal/list endpoint.
@MSzalowski MSzalowski added the 🖥 Frontend Frontend related label Apr 9, 2024
@MSzalowski MSzalowski self-assigned this Apr 9, 2024
@MSzalowski MSzalowski mentioned this issue Apr 9, 2024
Closed
@MSzalowski
Copy link
Contributor Author

Backend task that covers that issue: #640

JanJaroszczak added a commit that referenced this issue Apr 16, 2024
@JanJaroszczak
[#674] GA Search - Voted on - Add search functionality
c8f1df5
@JanJaroszczak JanJaroszczak mentioned this issue Apr 16, 2024
Merged
5 tasks
@JanJaroszczak JanJaroszczak linked a pull request Apr 16, 2024 that will close this issue
[#674] GA Search - Voted on - Add search functionality #735
Merged
5 tasks
JanJaroszczak added a commit that referenced this issue Apr 16, 2024
@JanJaroszczak
Merge pull request #735 from IntersectMBO/674-ga-search-voted-on-add-…
c001213 
…search-functionality

[#674] GA Search - Voted on - Add search functionality
@pmbinapps
Copy link

Voting not possible with current wallets

@pmbinapps
Copy link

OK: checked here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#674] GA Search - Voted on - Add search functionality IntersectMBO/govtool
3 participants
@MSzalowski @JanJaroszczak @pmbinapps