Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change terminology of "sole voter" to "direct voter" #880

Closed
Ryun1 opened this issue Apr 26, 2024 · 11 comments · Fixed by #890
Closed

Change terminology of "sole voter" to "direct voter" #880

Ryun1 opened this issue Apr 26, 2024 · 11 comments · Fixed by #890
Assignees
Labels
🖥 Frontend Frontend related

Comments

@Ryun1
Copy link
Member

Ryun1 commented Apr 26, 2024

Why

After comms review, sole voter was determined to be a bad name.

What

Replacing all user facing copy of "sole voter" to be "direct voter"

How

by using ctrl-f

@Ryun1 Ryun1 added the 🖥 Frontend Frontend related label Apr 26, 2024
@Sworzen1 Sworzen1 self-assigned this Apr 29, 2024
@Sworzen1 Sworzen1 linked a pull request Apr 30, 2024 that will close this issue
5 tasks
@pmbinapps
Copy link

OK on Dashboard

NOT OK for retired Sole Voter(Direct Voter)

Image

@MSzalowski MSzalowski reopened this May 8, 2024
@Sworzen1 Sworzen1 assigned vercia and unassigned vercia May 14, 2024
@pmbinapps
Copy link

NOT OK - 'DRep' text used now instead Direct Voter

Image

@MSzalowski
Copy link
Contributor

That is already done with #957

@pmbinapps
Copy link

pmbinapps commented May 15, 2024

OK when user is Direct Voter

Image

NOT OK - on details -page - 'SoleVoter' is used

Image

NOT OK - edit Metadata should not be visible, as DirectVoter is not Registered with metadata

@m-i-k-e could you confirm?

@pmbinapps pmbinapps assigned pmbinapps and unassigned pmbinapps May 15, 2024
@m-i-k-e
Copy link

m-i-k-e commented May 16, 2024

@pmbinapps Correct: "Direct Voters" don't have any metadata to edit.

@m-i-k-e
Copy link

m-i-k-e commented May 16, 2024

OK, I have changed the main Figma file to say "Direct Voter" instead of "Sole Voter"

@m-i-k-e
Copy link

m-i-k-e commented May 16, 2024

@pmbinapps @MSzalowski To recap: 'Direct Voter's' listings don't show up in the DRep directory. However, if a user knows the drep ID of a Direct Voter, and they search for it, it should show and there should be a detail page for it. This will not have any metadata on it. I'm not sure what happens now, as this is not able to be tested.

Whatever state of affairs that happens now should be ok, as long as the Direct Voter is not listed in the DRep directory. In the future, we will build Voting Histories for every voter, and therefore in the future the Direct Voter's page could have value to them. But we are not there today.

@m-i-k-e
Copy link

m-i-k-e commented May 16, 2024

A similar text issue to changing this text is #911. I've made both of these changes in Figma, and they are ready for devving.

@pmbinapps
Copy link

@m-i-k-e issue mentioned here is tracked here

@MSzalowski MSzalowski assigned MSzalowski and unassigned MSzalowski and Sworzen1 Jun 13, 2024
@MSzalowski
Copy link
Contributor

Issue no longer exists. Could you please retest it @pmbinapps?

@pmbinapps
Copy link

OK - Sole Voter text is not occurring anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 Frontend Frontend related
Projects
Status: Done
6 participants