Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to delegate to myself as a drep after delegating to Abstain #904

Closed
m-i-k-e opened this issue Apr 30, 2024 · 15 comments · Fixed by #965
Closed

No option to delegate to myself as a drep after delegating to Abstain #904

m-i-k-e opened this issue Apr 30, 2024 · 15 comments · Fixed by #965
Assignees
Labels
🐛 Bug Something isn't working

Comments

@m-i-k-e
Copy link

m-i-k-e commented Apr 30, 2024

Context & versions

staging.sanchonoe

https://www.loom.com/share/2fbab1772d424095b0de8833c029b559?sid=7f22a55c-2a29-441a-977a-a5ddbb7cf313

Steps to reproduce

  1. Delegate to abstain
  2. try to delegate to yourself

Actual behavior

There is no delegate button on the 'your' dRep list 'card' or detail page, hence, not possible to self-delegate

Expected behavior

Able to self-delegate

@m-i-k-e m-i-k-e added the 🐛 Bug Something isn't working label Apr 30, 2024
@m-i-k-e
Copy link
Author

m-i-k-e commented Apr 30, 2024

The missing delegation buttons on the 'self' drep appear probably all the time: https://www.loom.com/share/310530ffd4a040a795520cff3e45563d?sid=32d30642-f48d-48ca-9cd8-c129d18afe46

@pmbinapps
Copy link

'Yourself' label wrong place mentioned in Loom comment (#904 (comment)) tracked here

@pmbinapps
Copy link

@m-i-k-e is it the concept of 'Delegating to Myself' replaced by being 'Sole Voter'?

DW: @MSzalowski

@m-i-k-e
Copy link
Author

m-i-k-e commented May 2, 2024

@pmbinapps @MSzalowski. The concept of sole voter and delegating to oneself are similar, but different. So someone might be a sole voter for a while, and then decide to become a Drep. In current govtool, they would have to become drep first, and then do a second action to delegate to themselves. Yes, this should be improved on the UX design side. But this is our current state.

To answer your question "is it the concept of 'Delegating to Myself' replaced by being 'Sole Voter'?" : No. However, if we make some User Experience tweaks, we can either mandatorily or optionally get the user to transfer their Voting Power when they become a Drep.

To add to the confusion, if I am a DREP, and then become a Sole Voter, my own voting power is automatically transferred to my Sole Voter account.

@pmbinapps
Copy link

To check showing Voting power value.

@pmbinapps
Copy link

Original Issue - with US with this feature here

@pmbinapps
Copy link

First attempt to see the button on DRep list was fine - Delegate button was shown - but transaction somehow failed with msg not enough founds - this is to be explored.
Recording here - first sec Button is visible:

Image

Next, button was not visible any more:

Image

To reproduce:

  1. Register as DRep
  2. Observe if transaction was successful.
  3. Copy you Drepid from card or Demo DApp
  4. Go to DRep Explorer - Drep list and search for you DRep id - you should be Active with Delegate button

@pmbinapps pmbinapps self-assigned this May 9, 2024
@m-i-k-e
Copy link
Author

m-i-k-e commented May 10, 2024

@pmbinapps Can you say why this is blocked?

@pmbinapps
Copy link

@m-i-k-e a deployment is not effective, fix is not visible on test, and dev envs, in the moment.

@m-i-k-e
Copy link
Author

m-i-k-e commented May 13, 2024

@pmbinapps I don't understand. If this is closed, then does that mean it won't be fixed?

@pmbinapps
Copy link

@m-i-k-e from event logs looks like it was auto-closed when a PR was made, from my perspective is in QA and is not finished yet.

@MSzalowski it could be that an Github action is Closing issues whey they are merged

@pmbinapps
Copy link

dev-sanchnet:
OK Now

Image

@pmbinapps
Copy link

OK ON test-sancho:

Image

@MSzalowski
Copy link
Contributor

@MSzalowski it could be that an Github action is Closing issues whey they are merged

Yes, we should have the config that doesn't move issues to done once they are merged. But this is not as important as the integration parts that we have currently in scope

@MSzalowski
Copy link
Contributor

@pmbinapps should that still be assigned to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants