DRep detail data doesn't match entered data

[m-i-k-e]

Context & versions

staging.sanchonet

Loom video: https://www.loom.com/share/cd01691c84524bb7bc66e64c38347a1b?sid=0db69671-c576-44b2-8c40-2b076cc2131a

Steps to reproduce

1. Become Drep
2. Look at Drep list or drep detail page

Actual behavior

Information on page does not match info entered when Drep created

Expected behavior

Info should match

[pmbinapps]

Current data are mocked:

[bosko-m]

Will be addressed once CIP-119 is resolved.

[bosko-m]

@l-br1 This might potentially go in a release as a known issue with appropriate message.

[m-i-k-e]

@l-br1 @bosko-m If we release this, we can watermark it as "Sample Data". I'm not a fan of this idea, I'd rather it worked, but if it can't:

[m-i-k-e]

@MSzalowski Could you please add some comments on the security of reading external files on the internet?

[MSzalowski]

Sure 👍
We have many sources of truth around metadata-related things.
The best to depend on (from the technical side) is the db-sync which reflects the chain data - that is what we have currently for the governance actions.
We could fetch the metadata from the metadata url (provided by db-sync) on the frontend side but that results in potential security breach due to bypassing content security policy.
However, we have the sub-backend allowing validation of the metadata (we get the metadata url and hash from db sync -> then we parse the metadata provided under this url and validate it against the hash).

We can take the metadata from that validation service (we've done it before when we had the similar issue with the gov action metadata missing in db-sync but that significantly increased loading time of the page (n of gov actions more number of requests)) and display them in both gov actions (as they are missing there now) and in DRep directory even though we don't have the CIP-119 active.

[MSzalowski]

@bosko-m We can provide the fix not involving the db-sync and cip-119 for that before the release, if only the release would be postponed for a day or two.

[bosko-m]

Thanks @MSzalowski , will have a decision the next day you are working.

[bosko-m]

@MSzalowski Please dont go with a workaround solution that doesnt imply CIP-119. According to @m-i-k-e suggestion, watermark the page with "Sample Data" text. @m-i-k-e is going to provide the design.
#908 (comment)

[m-i-k-e]

I've asked @kgrzonka to make some responsive designs in Figma

[m-i-k-e]

Responsive designs are in Figma, for "Sample Data", if needed. @MSzalowski

https://www.figma.com/design/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?m=auto&node-id=14108-90052&t=gvTaOGLOeJmm7BiJ-1

[m-i-k-e]

Still using mocked data 4 Jun.

[pmbinapps]

OK NOW:

• data shown on Details page

Recheck on test-sancho...

[pmbinapps]

OK NOW
https://test-sanchonet.govtool.byron.network/connected/drep_directory/drep1pzuxy8ukuvffjyyrdp8sxkzp3z8r57z5q0jtgxhwu3a22t9ppel

[m-i-k-e]

Cannot become DRep, so blocked for testing

[bosko-m]

@m-i-k-e Why cant you become DRep?

[m-i-k-e]

@bosko-m "Metadata not verified" error. See this issue: #1011

All DRep testing is blocked, as I can't become one.

[MSzalowski]

#1247 Unblocks this issue

[m-i-k-e]

This works now, closing as I can see the data.