Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Your DRep" needs showing on detail page #927

Closed
m-i-k-e opened this issue May 1, 2024 · 2 comments · Fixed by #985
Closed

"Your DRep" needs showing on detail page #927

m-i-k-e opened this issue May 1, 2024 · 2 comments · Fixed by #985
Assignees
@JanJaroszczak @pmbinapps
Labels
🐛 Bug Something isn't working

Comments

@m-i-k-e
Copy link

m-i-k-e commented May 1, 2024

Context & versions

staging.sanchonet

Steps to reproduce

  1. Delegate to a DRep
  2. Navigate to their detail page

Actual behavior

You can't see that this is your Drep

Expected behavior

You can see that this is your Drep - there is a design in Figma for this.
@m-i-k-e m-i-k-e added the 🐛 Bug Something isn't working label May 1, 2024
@pmbinapps
Copy link

Valid bug:

Image

@JanJaroszczak JanJaroszczak self-assigned this May 10, 2024
JanJaroszczak added a commit that referenced this issue May 10, 2024
@JanJaroszczak
[#927] Your DRep needs showing on detail page
ca5217a
@JanJaroszczak JanJaroszczak mentioned this issue May 10, 2024
Merged
5 tasks
@JanJaroszczak JanJaroszczak linked a pull request May 10, 2024 that will close this issue
[#927] Your DRep needs showing on detail page #985
Merged
5 tasks
JanJaroszczak added a commit that referenced this issue May 13, 2024
@JanJaroszczak
[#927] Fixes after CR
8bc4b74
JanJaroszczak added a commit that referenced this issue May 13, 2024
@JanJaroszczak
[#927] Your DRep needs showing on detail page
8b91031
JanJaroszczak added a commit that referenced this issue May 13, 2024
@JanJaroszczak
[#927] Fixes after CR
e33383b
JanJaroszczak added a commit that referenced this issue May 14, 2024
@JanJaroszczak
Merge pull request #985 from IntersectMBO/927-your-drep-needs-showing…
7c6003b 
…-on-detail-page

[#927] Your DRep needs showing on detail page
@pmbinapps
Copy link

OK on test-sancho:

Image

@pmbinapps pmbinapps self-assigned this May 14, 2024
@pmbinapps pmbinapps mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanJaroszczak JanJaroszczak

@pmbinapps pmbinapps

Labels
🐛 Bug Something isn't working
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#927] Your DRep needs showing on detail page IntersectMBO/govtool
3 participants
@m-i-k-e @JanJaroszczak @pmbinapps