Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#1575): Provide pdf api url from the env variables #1593

Merged
merged 1 commit into from
Jul 19, 2024
Merged

chore(#1575): Provide pdf api url from the env variables #1593

merged 1 commit into from
Jul 19, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • Add PDF_API_URL to the frontend config

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski requested review from teske00 and removed request for adgud, Ryun1, Sworzen1 and JanJaroszczak July 18, 2024 10:32
@MSzalowski MSzalowski linked an issue Jul 18, 2024 that may be closed by this pull request
PDF backend API axios instance #1575
Closed
@MSzalowski MSzalowski self-assigned this Jul 18, 2024
@MSzalowski MSzalowski mentioned this pull request Jul 18, 2024
Closed
teske00
teske00 approved these changes Jul 18, 2024
View reviewed changes
Copy link

@teske00 teske00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing the API URL to the PDF package looks fine

@MSzalowski MSzalowski force-pushed the chore/provide-pdf-api-url-from-the-env-variables branch from a554c45 to 1083782 Compare July 19, 2024 07:13
@MSzalowski MSzalowski requested a review from placek July 19, 2024 08:17
@MSzalowski MSzalowski merged commit 4708192 into develop Jul 19, 2024
7 checks passed
@MSzalowski MSzalowski deleted the chore/provide-pdf-api-url-from-the-env-variables branch July 19, 2024 12:59
@bosko-m
Copy link
Contributor

bosko-m commented Jul 23, 2024

So this one is done @MSzalowski ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teske00 teske00 teske00 approved these changes

@placek placek placek approved these changes

Assignees

@MSzalowski MSzalowski

Labels
🏗 Infrastructure
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF backend API axios instance
4 participants
@MSzalowski @bosko-m @placek @teske00