Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1612): Fix connection to the metadata-validation service #1618

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix(#1612): Fix connection to the metadata-validation service #1618

merged 2 commits into from
Jul 29, 2024

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Jul 26, 2024 •
edited
Loading

List of changes

Checklist

  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Known issue

Response from metadata-validation fails on parsing.

@MSzalowski MSzalowski requested a review from Ryun1 as a code owner July 26, 2024 15:43
@MSzalowski MSzalowski linked an issue Jul 26, 2024 that may be closed by this pull request
[BE] GET /drep/list throws 500 after resync on db-sync 5.1.0 and node 9.0.0 #1612
Closed
@MSzalowski MSzalowski force-pushed the fix/1612-be-get-dreplist-throws-500-after-resync-on-db-sync-510-and-node-900 branch 3 times, most recently from 9c09c34 to 7b588bd Compare July 26, 2024 17:34
@MSzalowski MSzalowski requested a review from placek July 26, 2024 17:51
@MSzalowski MSzalowski requested a review from jankun4 July 29, 2024 08:38
@MSzalowski MSzalowski assigned MSzalowski and unassigned jankun4 Jul 29, 2024
placek
placek approved these changes Jul 29, 2024
View reviewed changes
govtool/backend/src/VVA/Metadata.hs Outdated
Just x -> return $ Right x) else return $ Right "")
if not metadataEnabled
then return $ MetadataValidationResult True (Just "Metadata validation disabled") Nothing
else do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation please

@MSzalowski MSzalowski force-pushed the fix/1612-be-get-dreplist-throws-500-after-resync-on-db-sync-510-and-node-900 branch from 7b588bd to 6204f1d Compare July 29, 2024 10:11
@MSzalowski MSzalowski merged commit d648c52 into develop Jul 29, 2024
2 checks passed
@MSzalowski MSzalowski deleted the fix/1612-be-get-dreplist-throws-500-after-resync-on-db-sync-510-and-node-900 branch July 29, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankun4 jankun4 jankun4 approved these changes

@placek placek placek approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees

@MSzalowski MSzalowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] GET /drep/list throws 500 after resync on db-sync 5.1.0 and node 9.0.0
3 participants
@MSzalowski @placek @jankun4